'Re: Review Request 127717: Fix error when destroying an default constructed KEduVocDocument'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 127717: Fix error when destroying an default constructed KEduVocDocument
From:       Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date:       2016-05-30 15:47:47
Message-ID: 20160530154747.29452.4168 () mimi ! kde ! org
[Download RAW message or body]

--===============5779535207307463500==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127717/
-----------------------------------------------------------

(Updated Mai 30, 2016, 3:47 nachm.)

Review request for KDE Edu.

Changes
-------

Splitted emptydocumenttest into separate header and source file.

Repository: libkeduvocdocument

Description
-------

When a KEduVocDocument which was constructed by the default constructor
becomes destructed, the error message "QFile::remove: Empty or null
file name" is given on stderr.

Since the file name of the KAutoSaveFile was not set in the default
constructor, the KAutoSaveFile::remove() method in ~KEduVocDocument()
have given this error message. Removed this method call and the
following KAutoSaveFile::releaseLock(), because they are called in the
KAutoSaveFile destructor as well but with check for file name.

Added unit test emptydocumenttest to proof the bugfix.

Since I'm not a cmake expert, I hope the test was added in the right way. I would be \
thankful for improvements.

Diffs (updated)
-----

  .gitignore PRE-CREATION 
  keduvocdocument/autotests/CMakeLists.txt 05580b6c5e8ad88fd15971cc6194aa4c22ffb558 
  keduvocdocument/autotests/emptydocumenttest.h PRE-CREATION 
  keduvocdocument/autotests/emptydocumenttest.cpp PRE-CREATION 
  keduvocdocument/keduvocdocument.cpp e8e48e90ef70477e18559936c3cb36fed492d543 

Diff: https://git.reviewboard.kde.org/r/127717/diff/

Testing
-------

Unit test emptydocumenttest

Thanks,

Hartmut Riesenbeck

--===============5779535207307463500==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127717/">https://git.reviewboard.kde.org/r/127717/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>

<p style="color: grey;"><i>Updated Mai 30, 2016, 3:47 nachm.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Splitted emptydocumenttest into separate header and source file.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When a KEduVocDocument which was constructed by the \
default constructor becomes destructed, the error message "QFile::remove: Empty or \
null file name" is given on stderr.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since the file name of the KAutoSaveFile was not set \
in the default constructor, the KAutoSaveFile::remove() method in ~KEduVocDocument()
have given this error message. Removed this method call and the
following KAutoSaveFile::releaseLock(), because they are called in the
KAutoSaveFile destructor as well but with check for file name.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added unit test emptydocumenttest to proof the \
bugfix.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since I'm not a cmake expert, I hope the test was \
added in the right way. I would be thankful for improvements.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit test emptydocumenttest</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>

 <li>keduvocdocument/autotests/CMakeLists.txt <span style="color: \
grey">(05580b6c5e8ad88fd15971cc6194aa4c22ffb558)</span></li>

 <li>keduvocdocument/autotests/emptydocumenttest.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>keduvocdocument/autotests/emptydocumenttest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>keduvocdocument/keduvocdocument.cpp <span style="color: \
grey">(e8e48e90ef70477e18559936c3cb36fed492d543)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127717/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5779535207307463500==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 