[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 127881: Fix theme cache path handling
From: Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date: 2016-05-29 15:58:04
Message-ID: 20160529155804.8640.11929 () mimi ! kde ! org
[Download RAW message or body]
--===============0821599658385546055==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127881/
-----------------------------------------------------------
(Updated May 29, 2016, 3:58 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Changes
-------
Submitted with commit f766452408cc64a75b8782e499a6a8c4f64b3ba2 by Hartmut Riesenbeck to branch \
master.
Repository: parley
Description
-------
When path to theme cache file does not exitst (e.g. after a fresh
installation) it is not created automatically which caused the
following error to be shown on stderr while reading and writing:
"QIODevice::read (QFile, "/path/to/theme/cache/startpagethemecache.bin"
): device not open"
Automatic creation of theme cache path is added. Location of cache file
is moved to QStandardPaths::CacheLocation.
Because for me it looks like that the theme image cache is what its name shows, a cache. I \
think that it's better to store it at QStandardPaths::CacheLocation rather then \
QStandardPaths::DataLocation.
Diffs
-----
src/practice/imagecache.h 26afb8a5439d0909a8410c992eadd9cbe021fc5c
src/practice/imagecache.cpp 9d01395804c6bce3551743292790e6b642ab9337
src/practice/themedbackgroundrenderer.cpp 7623d69369e189abd66c4fff39b023fae32b73d1
Diff: https://git.reviewboard.kde.org/r/127881/diff/
Testing
-------
Thanks,
Hartmut Riesenbeck
--===============0821599658385546055==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127881/">https://git.reviewboard.kde.org/r/127881/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated May 29, 2016, 3:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
f766452408cc64a75b8782e499a6a8c4f64b3ba2 by Hartmut Riesenbeck to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When path to \
theme cache file does not exitst (e.g. after a fresh installation) it is not created \
automatically which caused the following error to be shown on stderr while reading and \
writing:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">"QIODevice::read (QFile, \
"/path/to/theme/cache/startpagethemecache.bin" ): device not open"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Automatic creation of theme cache path is added. Location of cache file is moved to \
QStandardPaths::CacheLocation.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Because for me it looks like that the theme image \
cache is what its name shows, a cache. I think that it's better to store it at \
QStandardPaths::CacheLocation rather then QStandardPaths::DataLocation.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/imagecache.h <span style="color: \
grey">(26afb8a5439d0909a8410c992eadd9cbe021fc5c)</span></li>
<li>src/practice/imagecache.cpp <span style="color: \
grey">(9d01395804c6bce3551743292790e6b642ab9337)</span></li>
<li>src/practice/themedbackgroundrenderer.cpp <span style="color: \
grey">(7623d69369e189abd66c4fff39b023fae32b73d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127881/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0821599658385546055==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic