[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 127561: Prevent string cropping in bar widget and make practice button visible
From: Andreas Cord-Landwehr <cordlandwehr () kde ! org>
Date: 2016-05-27 10:52:11
Message-ID: 20160527105211.6029.31498 () mimi ! kde ! org
[Download RAW message or body]
--===============7448016476839656985==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127561/#review95916
-----------------------------------------------------------
Ship it!
Ship It!
- Andreas Cord-Landwehr
On April 3, 2016, 9:45 vorm., Dimitris Kardarakos wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127561/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 9:45 vorm.)
>
>
> Review request for KDE Edu.
>
>
> Repository: parley
>
>
> Description
> -------
>
> In dashboard page, a couple of issues have been identified in collection widget.
> 1. When the translation of string "%1 word due" is slightly longer than the English \
> one or %1 is a large number, string is cropped. 2. Practice button does not seem \
> clickable, using the default breeze theme and reference theme of parley. Even \
> worse, when breeze dark is used, due to the forcibly white background of collection \
> widget, practice button text is unreadable. I have addressed these issues by:
> - Changing bar widget size to 2-lines, increasing also slightly the width of the \
> collection widget
> - Wrapping the text of bar widget
> - Restoring theme colors to practice button (background was set to white due to \
> collection widget white background)
>
> Diffs
> -----
>
> src/dashboard/barwidget.cpp 61b6e43
> src/dashboard/collectionwidget.cpp 7925871
>
> Diff: https://git.reviewboard.kde.org/r/127561/diff/
>
>
> Testing
> -------
>
> Checked bar widget string presentation as well as practice button visibility using \
> combinations of the following:
> - Plasma Breeze (default) theme
> - Plasma Breeze Dark theme
> - Parley default theme
> - Parley bees theme
>
>
> File Attachments
> ----------------
>
> Dashboard (before patch)
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/03/2c264833-6deb-41c0-bb8d-fff1fb242564__before.png
> Dashboard (after patching)
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/03/c23368b9-482c-4d5d-8633-9c220428cbbc__after.png
>
>
> Thanks,
>
> Dimitris Kardarakos
>
>
--===============7448016476839656985==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127561/">https://git.reviewboard.kde.org/r/127561/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Andreas Cord-Landwehr</p>
<br />
<p>On April 3rd, 2016, 9:45 vorm. UTC, Dimitris Kardarakos wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>
<p style="color: grey;"><i>Updated April 3, 2016, 9:45 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In dashboard page, a couple of issues have been \
identified in collection widget. 1. When the translation of string "%1 word due" is \
slightly longer than the English one or %1 is a large number, string is cropped. 2. \
Practice button does not seem clickable, using the default breeze theme and reference \
theme of parley. Even worse, when breeze dark is used, due to the forcibly white \
background of collection widget, practice button text is unreadable. I have addressed \
these issues by:
- Changing bar widget size to 2-lines, increasing also slightly the width of the \
collection widget
- Wrapping the text of bar widget
- Restoring theme colors to practice button (background was set to white due to \
collection widget white background)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Checked bar widget string presentation as well as \
practice button visibility using combinations of the following:</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Plasma Breeze (default) theme</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Plasma Breeze Dark theme</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Parley default \
theme</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Parley bees theme</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dashboard/barwidget.cpp <span style="color: grey">(61b6e43)</span></li>
<li>src/dashboard/collectionwidget.cpp <span style="color: \
grey">(7925871)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127561/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/03/2c264833-6deb-41c0-bb8d-fff1fb242564__before.png">Dashboard \
(before patch)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/03/c23368b9-482c-4d5d-8633-9c220428cbbc__after.png">Dashboard \
(after patching)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7448016476839656985==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic