[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 127661: Phabricator T1661: Re-positioning axis label.
From: Alexander Semke <alexander.semke () web ! de>
Date: 2016-04-24 20:10:37
Message-ID: 20160424201037.15355.828 () mimi ! kde ! org
[Download RAW message or body]
--===============5109583661556687922==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127661/#review94815
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Semke
On April 24, 2016, Mittag, Anu Mittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127661/
> -----------------------------------------------------------
>
> (Updated April 24, 2016, Mittag)
>
>
> Review request for KDE Edu, Alexander Semke and Garvit Khatri.
>
>
> Repository: labplot
>
>
> Description
> -------
>
> These are the changes I have made till now, have implemented the idea of changing \
> offset to offsetX and offsetY.But according to the discussion which I had with \
> asemke on phabricator task I will now remove the limits of offset and rename it to \
> 'x' and 'y' and then finally make it dragable with the click of mouse.
>
> Diffs
> -----
>
> src/backend/worksheet/plots/cartesian/Axis.h 03932c6
> src/backend/worksheet/plots/cartesian/Axis.cpp b56d9c5
> src/backend/worksheet/plots/cartesian/AxisPrivate.h cc0a659
> src/backend/worksheet/plots/cartesian/CartesianPlot.cpp bdfae24
> src/kdefrontend/ui/labelwidget.ui 06b058f
> src/kdefrontend/widgets/LabelWidget.h 72bcf09
> src/kdefrontend/widgets/LabelWidget.cpp 4ac385c
>
> Diff: https://git.reviewboard.kde.org/r/127661/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anu Mittal
>
>
--===============5109583661556687922==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127661/">https://git.reviewboard.kde.org/r/127661/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alexander Semke</p>
<br />
<p>On April 24th, 2016, Mittag UTC, Anu Mittal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Semke and Garvit Khatri.</div>
<div>By Anu Mittal.</div>
<p style="color: grey;"><i>Updated April 24, 2016, Mittag</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
labplot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">These are the changes I have made till now, have \
implemented the idea of changing offset to offsetX and offsetY.But according to the \
discussion which I had with asemke on phabricator task I will now remove the limits \
of offset and rename it to 'x' and 'y' and then finally make it dragable with the \
click of mouse.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backend/worksheet/plots/cartesian/Axis.h <span style="color: \
grey">(03932c6)</span></li>
<li>src/backend/worksheet/plots/cartesian/Axis.cpp <span style="color: \
grey">(b56d9c5)</span></li>
<li>src/backend/worksheet/plots/cartesian/AxisPrivate.h <span style="color: \
grey">(cc0a659)</span></li>
<li>src/backend/worksheet/plots/cartesian/CartesianPlot.cpp <span style="color: \
grey">(bdfae24)</span></li>
<li>src/kdefrontend/ui/labelwidget.ui <span style="color: \
grey">(06b058f)</span></li>
<li>src/kdefrontend/widgets/LabelWidget.h <span style="color: \
grey">(72bcf09)</span></li>
<li>src/kdefrontend/widgets/LabelWidget.cpp <span style="color: \
grey">(4ac385c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127661/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5109583661556687922==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic