'Re: Review Request 127505: Parley: Randomize order of letters in Mixed Letters Practice'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 127505: Parley: Randomize order of letters in Mixed Letters Practice
From:       Julian Helfferich <julian.helfferich () googlemail ! com>
Date:       2016-04-03 19:35:32
Message-ID: 20160403193532.8263.70489 () mimi ! kde ! org
[Download RAW message or body]

--===============2395590777911480140==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127505/
-----------------------------------------------------------

(Updated April 3, 2016, 7:35 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Inge Wallin.

Changes
-------

Submitted with commit 62ca441f7d4777a96c9950737793747c47da63ac by Julian Helfferich \
to branch Applications/16.04.

Bugs: 360239
    http://bugs.kde.org/show_bug.cgi?id=360239

Repository: parley

Description
-------

The order of letters in the Mixed Letter Practice is currently not randomized. \
Instead, the letters are only shifted vertically (see bug 360239).

Now, I use KRandomSequence::randomize() to shuffle the list of characters comprising \
the solution. The KRandomSequence is a member of MixedLettersModeWidget. Thus, it \
gets instantiated each time the Mixed Letters Practice is started. I also use \
KRandomSequence::getInt() instead of KRandom::random() for consistency.

I have added Inge Wallin to the reviewers, because they replaced KRandomSequence with \
KRandom about a year ago. Is there a good reason not to use KRandomSequence?

Diffs
-----

  src/practice/mixedlettersmodewidget.h f2acaa1 
  src/practice/mixedlettersmodewidget.cpp adc53cd 

Diff: https://git.reviewboard.kde.org/r/127505/diff/

Testing
-------

Build and tested on Kubuntu 15.10:

Practiced vocabulary using Mixed Letter Practice and confirmed that letters are \
randomized.

Thanks,

Julian Helfferich

--===============2395590777911480140==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127505/">https://git.reviewboard.kde.org/r/127505/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Julian Helfferich.</div>

<p style="color: grey;"><i>Updated April 3, 2016, 7:35 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 62ca441f7d4777a96c9950737793747c47da63ac by Julian \
Helfferich to branch Applications/16.04.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=360239">360239</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The order of letters in the Mixed Letter Practice is \
currently not randomized. Instead, the letters are only shifted vertically (see bug \
360239).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now, I use KRandomSequence::randomize() to shuffle the \
list of characters comprising the solution. The KRandomSequence is a member of \
MixedLettersModeWidget. Thus, it gets instantiated each time the Mixed Letters \
Practice is started. I also use KRandomSequence::getInt() instead of \
KRandom::random() for consistency.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I have added Inge \
Wallin to the reviewers, because they replaced KRandomSequence with KRandom about a \
year ago. Is there a good reason not to use KRandomSequence?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build and tested on Kubuntu 15.10:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Practiced vocabulary using Mixed Letter Practice and confirmed that letters \
are randomized.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/practice/mixedlettersmodewidget.h <span style="color: \
grey">(f2acaa1)</span></li>

 <li>src/practice/mixedlettersmodewidget.cpp <span style="color: \
grey">(adc53cd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127505/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2395590777911480140==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 