'Re: Review Request 127157: Prevent array access with negativ index'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 127157: Prevent array access with negativ index
From:       Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date:       2016-02-29 21:51:25
Message-ID: 20160229215125.32153.2107 () mimi ! kde ! org
[Download RAW message or body]

--===============8578183549495177012==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Feb. 28, 2016, 9:35 nachm., Andreas Cord-Landwehr wrote:
> > Ship It!
> 
> Hartmut Riesenbeck wrote:
> Hi Andreas,
> how to submit the change to the repository?
> 
> Best regards
> Hartmut
> 
> Andreas Cord-Landwehr wrote:
> Hi, if you do not have push rights, I can commit it for you.

No, I haven't push rights. It would be nice if you could commit it. Thanks!

- Hartmut

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127157/#review92865
-----------------------------------------------------------

On Feb. 23, 2016, 9:14 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127157/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 9:14 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> To adjust the practice date of expired entries
> in EntryFilter::expireEntries() the expire item
> time was read from the Prefs object. When grade
> of the expired item was 1, the argument of
> Prefs::expireItem() became -1. This resulted in
> an access of an C array with negativ index in
> Prefs::expireItem(). For grade 2 the prefs value
> was not defined in the config file - zero was
> returned by default. For this two cases the
> practice date was set to current time as a
> defined state.
> 
> 
> Diffs
> -----
> 
> src/collection/entryfilter.cpp 5264226 
> 
> Diff: https://git.reviewboard.kde.org/r/127157/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
> 

--===============8578183549495177012==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127157/">https://git.reviewboard.kde.org/r/127157/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Februar 28th, 2016, 9:35 nachm. UTC, <b>Andreas \
Cord-Landwehr</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

 <p>On Februar 29th, 2016, 9:11 nachm. UTC, <b>Hartmut Riesenbeck</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Andreas, how to submit the change to the repository?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Best regards Hartmut</p></pre>
 </blockquote>

 <p>On Februar 29th, 2016, 9:37 nachm. UTC, <b>Andreas Cord-Landwehr</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, \
if you do not have push rights, I can commit it for you.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, I \
haven't push rights. It would be nice if you could commit it. Thanks!</p></pre> <br \
/>

<p>- Hartmut</p>

<br />
<p>On Februar 23rd, 2016, 9:14 nachm. UTC, Hartmut Riesenbeck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>

<p style="color: grey;"><i>Updated Feb. 23, 2016, 9:14 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To adjust the practice date of expired entries in \
EntryFilter::expireEntries() the expire item time was read from the Prefs object. \
When grade of the expired item was 1, the argument of
Prefs::expireItem() became -1. This resulted in
an access of an C array with negativ index in
Prefs::expireItem(). For grade 2 the prefs value
was not defined in the config file - zero was
returned by default. For this two cases the
practice date was set to current time as a
defined state.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/collection/entryfilter.cpp <span style="color: grey">(5264226)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127157/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8578183549495177012==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 