[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 127156: Call off EntryFilter::expireEntries has no effect
From: Andreas Cord-Landwehr <cordlandwehr () kde ! org>
Date: 2016-02-28 21:41:15
Message-ID: 20160228214115.12079.53663 () mimi ! kde ! org
[Download RAW message or body]
--===============2647301159179029352==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127156/#review92866
-----------------------------------------------------------
src/collection/entryfilter.cpp (line 115)
<https://git.reviewboard.kde.org/r/127156/#comment63335>
For me it would look more logical to just exchange the order of \
expireEntries(pass) and collectEntries(pass). Since otherwise, the behavior of \
collectEntries changes and I am not sure that its method name reflects the new \
behavior.
- Andreas Cord-Landwehr
On Feb. 23, 2016, 9:08 nachm., Hartmut Riesenbeck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127156/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 9:08 nachm.)
>
>
> Review request for KDE Edu.
>
>
> Repository: parley
>
>
> Description
> -------
>
> In EntryFilter::expireEntries() the set
> EntryFilter::m_entries is checked for entries
> which hasn't practiced for a defined amount of
> time and decreases the grad if this was expired.
>
> But at time of calling expireEntries() this could
> not work because m_entries was not intialisised
> and empty. The method call was moved to a place
> where m_entries is filled and cleaned of invalid
> entries.
>
>
> Diffs
> -----
>
> src/collection/entryfilter.cpp 5264226
>
> Diff: https://git.reviewboard.kde.org/r/127156/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hartmut Riesenbeck
>
>
--===============2647301159179029352==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127156/">https://git.reviewboard.kde.org/r/127156/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127156/diff/1/?file=445190#file445190line116" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/collection/entryfilter.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">116</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">collectEntries</span><span class="p">(</span><span \
class="n">pass</span><span class="p">);</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">115</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">collectEntries</span><span class="p">(</span><span \
class="n">pass</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
me it would look more logical to just exchange the order of expireEntries(pass) and \
collectEntries(pass). Since otherwise, the behavior of collectEntries changes and I \
am not sure that its method name reflects the new behavior.</p></pre> </div>
</div>
<br />
<p>- Andreas Cord-Landwehr</p>
<br />
<p>On Februar 23rd, 2016, 9:08 nachm. UTC, Hartmut Riesenbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2016, 9:08 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In EntryFilter::expireEntries() the set \
EntryFilter::m_entries is checked for entries which hasn't practiced for a defined \
amount of time and decreases the grad if this was expired.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">But at time of calling expireEntries() this could not \
work because m_entries was not intialisised and empty. The method call was moved to \
a place where m_entries is filled and cleaned of invalid
entries.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/entryfilter.cpp <span style="color: grey">(5264226)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127156/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2647301159179029352==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic