[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 125303: [Cantor] Drop KGlobalSettings and implements a substitute to KGlobalSetti
From: Dominik Haumann <dhaumann () kde ! org>
Date: 2016-02-15 18:19:07
Message-ID: 20160215181907.26765.83326 () mimi ! kde ! org
[Download RAW message or body]
--===============0853925539718221248==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125303/#review92414
-----------------------------------------------------------
I'm a bit late to this, but does this really work?
In KTextEditor, we install an event filter to the qApp, and check for the event type \
PaletteChange, and then update our caches. Trying to use qApp::paletteChanged() does \
nothing when changing the KDE Color scheme...
Does this patch really work for Cantor???
- Dominik Haumann
On Sept. 18, 2015, 9:25 p.m., Filipe Saraiva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125303/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 9:25 p.m.)
>
>
> Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal Humpula, \
> and Jeremy Whiting.
>
> Repository: cantor
>
>
> Description
> -------
>
> Hi devs, I am finishing the drop of KDELibs4Support from Cantor. I am removing \
> KGlobalSettings now, but I need to port kdisplayPaletteChanged signal. I wrote this \
> patch based on this accepted review request \
> [114619](https://git.reviewboard.kde.org/r/114619/) but I don't know if it is \
> correct.
> Well, just say me if it is ok for the moment. I don't know how to test specifically \
> this feature.
>
> Diffs
> -----
>
> src/lib/defaulthighlighter.h e33256a
> src/lib/defaulthighlighter.cpp 45c7063
>
> Diff: https://git.reviewboard.kde.org/r/125303/diff/
>
>
> Testing
> -------
>
> * Build ok;
> * Installation ok;
> * I used Cantor for some time, looks like ok.
>
>
> Thanks,
>
> Filipe Saraiva
>
>
--===============0853925539718221248==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125303/">https://git.reviewboard.kde.org/r/125303/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a \
bit late to this, but does this really work?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In KTextEditor, we \
install an event filter to the qApp, and check for the event type PaletteChange, and \
then update our caches. Trying to use qApp::paletteChanged() does nothing when \
changing the KDE Color scheme...</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Does this patch really \
work for Cantor???</p></pre> <br />
<p>- Dominik Haumann</p>
<br />
<p>On September 18th, 2015, 9:25 p.m. UTC, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal \
Humpula, and Jeremy Whiting.</div> <div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2015, 9:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi devs, I am finishing the drop of KDELibs4Support \
from Cantor. I am removing KGlobalSettings now, but I need to port \
kdisplayPaletteChanged signal. I wrote this patch based on this accepted review \
request <a href="https://git.reviewboard.kde.org/r/114619/" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">114619</a> but I don't know if it is correct.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
just say me if it is ok for the moment. I don't know how to test specifically this \
feature.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Installation ok;</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">I used Cantor for some time, looks like \
ok.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/defaulthighlighter.h <span style="color: grey">(e33256a)</span></li>
<li>src/lib/defaulthighlighter.cpp <span style="color: grey">(45c7063)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125303/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0853925539718221248==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic