[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 126279: Fix Bug 356233: Call saveAs setting file type to Kvtml and transform url 
From:       "Dimitris Kardarakos" <dimkard () gmail ! com>
Date:       2015-12-30 23:18:38
Message-ID: 20151230231838.30660.97797 () mimi ! kde ! org
[Download RAW message or body]

--===============4491669481193835277==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126279/
-----------------------------------------------------------

(Updated des. 30, 2015, 11:18 p.m.)


Status
------

This change has been discarded.


Review request for KDE Edu.


Bugs: 356233
    http://bugs.kde.org/show_bug.cgi?id=356233


Repository: parley


Description
-------

Fix "Bug 356233 - File is not writeable when creating a new collection" by \
calling saveAs setting file type to Kvtml and transforming url to local \
file format


Diffs
-----

  src/parleydocument.cpp edda984 

Diff: https://git.reviewboard.kde.org/r/126279/diff/


Testing
-------

Applying this patch in conjunction with removing \
plugins/google_images.desktop after installation (as a workaround to bug \
356104) I have managed to create and save new vocabulary collections (bug \
356233).

Tests:
1. Create new collection - Use "Save" functionality
2. Create new collection - Use "Save As" functionality
3. Create new collection - Leave without saving - Message displayed - Save


Thanks,

Dimitris Kardarakos


--===============4491669481193835277==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126279/">https://git.reviewboard.kde.org/r/126279/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>


<p style="color: grey;"><i>Updated des. 30, 2015, 11:18 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=356233">356233</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Fix "Bug 356233 - File is not \
writeable when creating a new collection" by calling saveAs setting file \
type to Kvtml and transforming url to local file format</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Applying this patch in \
conjunction with removing plugins/google_images.desktop after installation \
(as a workaround to bug 356104) I have managed to create and save new \
vocabulary collections (bug 356233).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Tests: 1. Create new collection - Use "Save" functionality
2. Create new collection - Use "Save As" functionality
3. Create new collection - Leave without saving - Message displayed - \
Save</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/parleydocument.cpp <span style="color: grey">(edda984)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126279/diff/" \
style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4491669481193835277==--


[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic