'Re: Review Request 126421: Do not claim 100% CPU when typing fast'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 126421: Do not claim 100% CPU when typing fast
From:       "Ian Schwarz" <m_105 () gmx ! de>
Date:       2015-12-18 20:45:40
Message-ID: 20151218204540.5237.72965 () mimi ! kde ! org
[Download RAW message or body]

--===============2151449026332588368==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126421/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 8:45 p.m.)

Review request for KDE Edu.

Repository: ktouch

Description (updated)
-------

Using Qt 4.8.7, KTouch claims 100% CPU and is very laggy in displaying letters (cf. \
https://bugs.kde.org/show_bug.cgi?id=346248 and \
https://bugs.kde.org/show_bug.cgi?id=350336). The attached diff corrects this \
behavior and fixes both bugs.

PLEASE NOTE THAT I DID NOT AUTHOR THIS DIFF, but Moritz Nisblé (see \
https://bugs.kde.org/show_bug.cgi?id=346248). I'd merely like to see the bug fixed. \
(Moritz notes that parts of his fix are "not nice but quite efficient." The current \
code is neither.)

Diffs
-----

  src/declarativeitems/lessonpainter.cpp dc8fc61 

Diff: https://git.reviewboard.kde.org/r/126421/diff/

Testing
-------

Compiles and fixes the problem.

Thanks,

Ian Schwarz

--===============2151449026332588368==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126421/">https://git.reviewboard.kde.org/r/126421/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Ian Schwarz.</div>

<p style="color: grey;"><i>Updated Dec. 18, 2015, 8:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktouch
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Using Qt 4.8.7, KTouch claims 100% CPU and is very \
laggy in displaying letters (cf. https://bugs.kde.org/show_bug.cgi?id=346248 and \
https://bugs.kde.org/show_bug.cgi?id=350336). The attached diff corrects this \
behavior and fixes both bugs.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">PLEASE NOTE THAT I DID \
NOT AUTHOR THIS DIFF, but Moritz Nisblé (see \
https://bugs.kde.org/show_bug.cgi?id=346248). I'd merely like to see the bug fixed. \
(Moritz notes that parts of his fix are "not nice but quite efficient." The current \
code is neither.)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles and fixes the problem.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeitems/lessonpainter.cpp <span style="color: \
grey">(dc8fc61)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126421/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2151449026332588368==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 