[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 123553: Remove private customized KAutoSaveFile. If regressions from this are fou
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-10-28 22:40:50
Message-ID: 20151028224050.14097.63195 () mimi ! kde ! org
[Download RAW message or body]
--===============0176036723591420434==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123553/#review87624
-----------------------------------------------------------
Ship it!
Ship It!
- Albert Astals Cid
On abr. 29, 2015, 12:22 a.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123553/
> -----------------------------------------------------------
>
> (Updated abr. 29, 2015, 12:22 a.m.)
>
>
> Review request for KDE Edu, Andreas Xavier and Inge Wallin.
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> Remove private customized KAutoSaveFile. If regressions from this are found, we \
> need to fix them in the KCoreAddons framework.
>
> Diffs
> -----
>
> keduvocdocument/CMakeLists.txt aa81492e8996750c57a97c7c8c1f28c5153f0c57
> keduvocdocument/autosave/kautosavefile.h b54eb6731ee895c9a33ca73d57a10057e49ace81
> keduvocdocument/autosave/kautosavefile.cpp 3b691a5cc868e4ecbf46346ed2fc4fc9bad81ed2 \
> keduvocdocument/autosave/kautosavefileprivate.h \
> a86b2e2ef57df8316bcf7a54cc8396122935d1d6 \
> keduvocdocument/autosave/kautosavefileprivate.cpp \
> 38d49b4b1665cc57ff5f409470dc5771b549fcf3 keduvocdocument/autotests/CMakeLists.txt \
> 98cd414509935da5f08428dcc04925d27389cbaa \
> keduvocdocument/autotests/kautosavefiletest.h \
> 41e60b0082ca57034e1b523ba688937f60511ee1 \
> keduvocdocument/autotests/kautosavefiletest.cpp \
> 8838f6ffe57f4dc3d6353ba78686b2f15224739f keduvocdocument/keduvocdocument.cpp \
> 5b0df4c6f204fa5865d9fa051c88858b2b115597
> Diff: https://git.reviewboard.kde.org/r/123553/diff/
>
>
> Testing
> -------
>
> Parley built with this still runs. I'm not sure what the problem is that the local \
> copy changes are trying to solve. The patches to upstream those changes can be seen \
> here: https://git.reviewboard.kde.org/r/121099 and \
> https://git.reviewboard.kde.org/r/119530 for reference.
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============0176036723591420434==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123553/">https://git.reviewboard.kde.org/r/123553/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On abril 29th, 2015, 12:22 a.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Andreas Xavier and Inge Wallin.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated abr. 29, 2015, 12:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove private customized KAutoSaveFile. If regressions from this are \
found, we need to fix them in the KCoreAddons framework.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Parley built with this still runs. I'm not sure what \
the problem is that the local copy changes are trying to solve. The patches to \
upstream those changes can be seen here: https://git.reviewboard.kde.org/r/121099 and \
https://git.reviewboard.kde.org/r/119530 for reference.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/CMakeLists.txt <span style="color: \
grey">(aa81492e8996750c57a97c7c8c1f28c5153f0c57)</span></li>
<li>keduvocdocument/autosave/kautosavefile.h <span style="color: \
grey">(b54eb6731ee895c9a33ca73d57a10057e49ace81)</span></li>
<li>keduvocdocument/autosave/kautosavefile.cpp <span style="color: \
grey">(3b691a5cc868e4ecbf46346ed2fc4fc9bad81ed2)</span></li>
<li>keduvocdocument/autosave/kautosavefileprivate.h <span style="color: \
grey">(a86b2e2ef57df8316bcf7a54cc8396122935d1d6)</span></li>
<li>keduvocdocument/autosave/kautosavefileprivate.cpp <span style="color: \
grey">(38d49b4b1665cc57ff5f409470dc5771b549fcf3)</span></li>
<li>keduvocdocument/autotests/CMakeLists.txt <span style="color: \
grey">(98cd414509935da5f08428dcc04925d27389cbaa)</span></li>
<li>keduvocdocument/autotests/kautosavefiletest.h <span style="color: \
grey">(41e60b0082ca57034e1b523ba688937f60511ee1)</span></li>
<li>keduvocdocument/autotests/kautosavefiletest.cpp <span style="color: \
grey">(8838f6ffe57f4dc3d6353ba78686b2f15224739f)</span></li>
<li>keduvocdocument/keduvocdocument.cpp <span style="color: \
grey">(5b0df4c6f204fa5865d9fa051c88858b2b115597)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123553/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0176036723591420434==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic