'Re: Review Request 125303: [Cantor] Drop KGlobalSettings and implements a substitute to KGlobalSetti'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 125303: [Cantor] Drop KGlobalSettings and implements a substitute to KGlobalSetti
From:       "Filipe Saraiva" <filipe () kde ! org>
Date:       2015-09-18 21:25:35
Message-ID: 20150918212535.2235.47075 () mimi ! kde ! org
[Download RAW message or body]

--===============1277460703976177452==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125303/
-----------------------------------------------------------

(Updated Sept. 18, 2015, 9:25 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal Humpula, and \
Jeremy Whiting.

Changes
-------

Submitted with commit b0ba31c71348d4924d9db561d1d54751a9d52b37 by Filipe Saraiva to \
branch master.

Repository: cantor

Description
-------

Hi devs, I am finishing the drop of KDELibs4Support from Cantor. I am removing \
KGlobalSettings now, but I need to port kdisplayPaletteChanged signal. I wrote this \
patch based on this accepted review request \
[114619](https://git.reviewboard.kde.org/r/114619/) but I don't know if it is \
correct.

Well, just say me if it is ok for the moment. I don't know how to test specifically \
this feature.

Diffs
-----

  src/lib/defaulthighlighter.h e33256a 
  src/lib/defaulthighlighter.cpp 45c7063 

Diff: https://git.reviewboard.kde.org/r/125303/diff/

Testing
-------

* Build ok;
* Installation ok;
* I used Cantor for some time, looks like ok.

Thanks,

Filipe Saraiva

--===============1277460703976177452==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125303/">https://git.reviewboard.kde.org/r/125303/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal \
Humpula, and Jeremy Whiting.</div> <div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated Sept. 18, 2015, 9:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b0ba31c71348d4924d9db561d1d54751a9d52b37 by Filipe \
Saraiva to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi devs, I am finishing the drop of KDELibs4Support \
from Cantor. I am removing KGlobalSettings now, but I need to port \
kdisplayPaletteChanged signal. I wrote this patch based on this accepted review \
request <a href="https://git.reviewboard.kde.org/r/114619/" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">114619</a> but I don't know if it is correct.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
just say me if it is ok for the moment. I don't know how to test specifically this \
feature.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Installation ok;</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">I used Cantor for some time, looks like \
ok.</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/defaulthighlighter.h <span style="color: grey">(e33256a)</span></li>

 <li>src/lib/defaulthighlighter.cpp <span style="color: grey">(45c7063)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125303/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1277460703976177452==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 