[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 125269: Remove eigen2 support completely
From: "Anton Gladky" <gladky.anton () gmail ! com>
Date: 2015-09-17 5:11:38
Message-ID: 20150917051138.2235.29702 () mimi ! kde ! org
[Download RAW message or body]
--===============0255918032062935581==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125269/
-----------------------------------------------------------
(Updated Sept. 17, 2015, 5:11 a.m.)
Review request for KDE Edu and Andreas Cord-Landwehr.
Changes
-------
add Edu group for reviewing
Repository: step
Description
-------
Remove eigen2 support completely
Diffs
-----
CMakeLists.txt 6aacfa4
step/gasgraphics.cc 1c16d82
step/polygongraphics.cc 95cbfe8
step/toolgraphics.cc 70416b1
stepcore/constraintsolver.cc f68a66e
stepcore/coulombforce.cc 6a0e580
stepcore/eulersolver.cc f932c66
stepcore/gas.h cebde4a
stepcore/gas.cc 21a066d
stepcore/gravitation.cc c177337
stepcore/particle.cc 0eee19f
stepcore/rigidbody.cc b918a82
stepcore/spring.cc 974e1cc
stepcore/tool.h cff449e
Diff: https://git.reviewboard.kde.org/r/125269/diff/
Testing
-------
This patch is applied in Debian [1] to remove eigen2-support completely, because new \
eigen3_3.3 (not released yet) will drop eigen2-constructions.
The only problem place, which needs to be good tested is the calculation of Vector2d \
forceV, which needed to be rewritten, see short discussion here [2].
[1] http://anonscm.debian.org/cgit/pkg-kde/applications/step.git/commit/?id=82b74dd0026bdb1560efc317c2fa013be08b6c17
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786351#22
Thanks,
Anton Gladky
--===============0255918032062935581==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125269/">https://git.reviewboard.kde.org/r/125269/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Anton Gladky.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 5:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">add Edu group for reviewing</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
step
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove eigen2 support completely</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch is applied in Debian [1] to remove \
eigen2-support completely, because new eigen3_3.3 (not released yet) will drop \
eigen2-constructions.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The only problem place, which needs to \
be good tested is the calculation of Vector2d forceV, which needed to be rewritten, \
see short discussion here [2].</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] \
http://anonscm.debian.org/cgit/pkg-kde/applications/step.git/commit/?id=82b74dd0026bdb1560efc317c2fa013be08b6c17
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786351#22</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6aacfa4)</span></li>
<li>step/gasgraphics.cc <span style="color: grey">(1c16d82)</span></li>
<li>step/polygongraphics.cc <span style="color: grey">(95cbfe8)</span></li>
<li>step/toolgraphics.cc <span style="color: grey">(70416b1)</span></li>
<li>stepcore/constraintsolver.cc <span style="color: grey">(f68a66e)</span></li>
<li>stepcore/coulombforce.cc <span style="color: grey">(6a0e580)</span></li>
<li>stepcore/eulersolver.cc <span style="color: grey">(f932c66)</span></li>
<li>stepcore/gas.h <span style="color: grey">(cebde4a)</span></li>
<li>stepcore/gas.cc <span style="color: grey">(21a066d)</span></li>
<li>stepcore/gravitation.cc <span style="color: grey">(c177337)</span></li>
<li>stepcore/particle.cc <span style="color: grey">(0eee19f)</span></li>
<li>stepcore/rigidbody.cc <span style="color: grey">(b918a82)</span></li>
<li>stepcore/spring.cc <span style="color: grey">(974e1cc)</span></li>
<li>stepcore/tool.h <span style="color: grey">(cff449e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125269/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0255918032062935581==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic