[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 125203: KF5 port
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2015-09-12 20:23:33
Message-ID: 20150912202333.24667.92125 () mimi ! kde ! org
[Download RAW message or body]
--===============9010905765290892628==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125203/#review85278
-----------------------------------------------------------
Mostly good, but the changes in src/detailinfodlg.cpp are wrong. You need to port \
away from KLocale to QLocale, not add new uses of KLocale.
- Jeremy Whiting
On Sept. 12, 2015, 2:17 p.m., Rahul Chowdhury wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125203/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2015, 2:17 p.m.)
>
>
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
>
>
> Repository: kalzium
>
>
> Description
> -------
>
> Port of KGlobal::locale()
>
>
> Diffs
> -----
>
> plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp dfcbc6d
> plasmoid/applet/psePlasmoid/Molmasscalculator.cpp ccf7d27
> plasmoid/engine/kalzium_engine.cpp da44c17
> src/detailinfodlg.cpp d8a3968
> src/kalzium.cpp fec6aa7
> src/tools/moleculeview.cpp a586b6d
>
> Diff: https://git.reviewboard.kde.org/r/125203/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rahul Chowdhury
>
>
--===============9010905765290892628==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125203/">https://git.reviewboard.kde.org/r/125203/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Mostly good, but the changes in src/detailinfodlg.cpp are wrong. You need \
to port away from KLocale to QLocale, not add new uses of KLocale.</p></pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On September 12th, 2015, 2:17 p.m. MDT, Rahul Chowdhury wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.</div>
<div>By Rahul Chowdhury.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2015, 2:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Port of KGlobal::locale()</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp <span style="color: \
grey">(dfcbc6d)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.cpp <span style="color: \
grey">(ccf7d27)</span></li>
<li>plasmoid/engine/kalzium_engine.cpp <span style="color: \
grey">(da44c17)</span></li>
<li>src/detailinfodlg.cpp <span style="color: grey">(d8a3968)</span></li>
<li>src/kalzium.cpp <span style="color: grey">(fec6aa7)</span></li>
<li>src/tools/moleculeview.cpp <span style="color: grey">(a586b6d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125203/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9010905765290892628==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic