[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 124851: Adjust location for kvtml files
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2015-08-27 2:25:43
Message-ID: 20150827022543.4103.23467 () mimi ! kde ! org
[Download RAW message or body]
--===============7616454895958927140==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124851/#review84437
-----------------------------------------------------------
For backwards compatibility, let's keep apps/kvtml for the time being. We can look at \
using just kvtml later on if there's a strong reason for doing so. I just pushed a \
fix to kanagram's knsrc file so knewstuff files will go to the right place (pushed to \
Applications/15.04, Applications/15.08 and master branches).
- Jeremy Whiting
On Aug. 20, 2015, 2:50 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124851/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 2:50 p.m.)
>
>
> Review request for KDE Edu and Jeremy Whiting.
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> QStandardPaths::GenericDataLocation returns "~/.local/share" as a
> writable path, which is not only a path which should be the default for
> $XDG_DATA_HOME [1] but is also the directory, where knewstuff puts
> downloaded files.
>
> Without this patch previously downloaded vocabularies which ended up
> in ~/.local/share/kvtml weren't found in kanagram, because it only
> searched in ~/.local/share/apps/kvtml.
>
> [1] http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
>
>
> Diffs
> -----
>
> keduvocdocument/sharedkvtmlfiles.cpp f153385b5d28eb807deaf7be6eed12e892056f75
>
> Diff: https://git.reviewboard.kde.org/r/124851/diff/
>
>
> Testing
> -------
>
> Vocabularies downloaded via knewstuff now show up in kanagram.
>
>
> Thanks,
>
> Heiko Becker
>
>
--===============7616454895958927140==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124851/">https://git.reviewboard.kde.org/r/124851/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
backwards compatibility, let's keep apps/kvtml for the time being. We can look at \
using just kvtml later on if there's a strong reason for doing so. I just pushed a \
fix to kanagram's knsrc file so knewstuff files will go to the right place (pushed to \
Applications/15.04, Applications/15.08 and master branches).</p></pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On August 20th, 2015, 2:50 p.m. MDT, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Jeremy Whiting.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2015, 2:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QStandardPaths::GenericDataLocation returns "~/.local/share" \
as a writable path, which is not only a path which should be the default for
$XDG_DATA_HOME [1] but is also the directory, where knewstuff puts
downloaded files.
Without this patch previously downloaded vocabularies which ended up
in ~/.local/share/kvtml weren't found in kanagram, because it only
searched in ~/.local/share/apps/kvtml.
[1] http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Vocabularies downloaded via knewstuff now show up in kanagram.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/sharedkvtmlfiles.cpp <span style="color: \
grey">(f153385b5d28eb807deaf7be6eed12e892056f75)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124851/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7616454895958927140==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic