[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 124168: [Cantor] Port plugin load mechanism to new KDE Frameworks 5 way
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-07-12 20:37:23
Message-ID: 20150712203723.22904.4798 () mimi ! kde ! org
[Download RAW message or body]
--===============8557159291147601603==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On July 3, 2015, 8:45 p.m., Filipe Saraiva wrote:
> > src/lib/CMakeLists.txt, lines 57-63
> > <https://git.reviewboard.kde.org/r/124168/diff/2/?file=382975#file382975line57>
> >
> > I would like to get some tips about how to port that \
> > _kcoreaddons_desktop_to_json_ to the new way.
> > How I change that _add_library_ above? I get some error messages when I try to \
> > compile it.
>
> Filipe Saraiva wrote:
> My doubt here is: is there anyway to use shared libraries with JSON metadata or we \
> need to use .desktop files yet?
> I master branch, src/lib/CMakeLists.txt has:
> > install( FILES cantor_backend.desktop DESTINATION \
> > ${KDE_INSTALL_KSERVICETYPES5DIR})
> > install( FILES cantor_assistant.desktop DESTINATION \
> > ${KDE_INSTALL_KSERVICETYPES5DIR})
> > install( FILES cantor_panelplugin.desktop DESTINATION \
> > ${KDE_INSTALL_KSERVICETYPES5DIR})
>
> Must I change it for JSON files or I must to use .desktop files yet?
>
> Aleix Pol Gonzalez wrote:
> What I've done in most occasions is just dropping the desktop files as the JSON \
> gets embedded in the .so file.
> Filipe Saraiva wrote:
> Sune reply me in devel-mail list for not to use any metadata file. What do you \
> think about it?
If you don't need it, then you can get away without it. (That would be the case if \
you just want to load all plugins, and don't need to know anything about them, other \
than the libraryName.
If you do need any metadata, Aleix suggestion to use JSON is just fine (I'd recommend \
that).
If you really need KService and KSycoca (for backwards compatibility, for example), \
you'll have to use .desktop files (and convert them to json during build using \
kcoreaddons_desktop_to_json().
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124168/#review82056
-----------------------------------------------------------
On July 3, 2015, 8:33 p.m., Filipe Saraiva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124168/
> -----------------------------------------------------------
>
> (Updated July 3, 2015, 8:33 p.m.)
>
>
> Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, and Sebastian \
> Kügler.
>
> Repository: cantor
>
>
> Description
> -------
>
> There is a new way to load plugins in KDE Frameworks 5 way. I ported Cantor plugins \
> support to it. Now Cantor is using K_PLUGIN_FACTORY_WITH_JSON, the plugin path is \
> the same of Qt5 ($QT_PLUGIN_PATH) and different types of Cantor plugins are \
> installed in different subdirectories (backends in backends in \
> ${KDE_INSTALL_PLUGINDIR}/cantor/backends, assistants in \
> ${KDE_INSTALL_PLUGINDIR}/cantor/assistants, and panels in \
> ${KDE_INSTALL_PLUGINDIR}/cantor/panels). KPluginInfo was changed to KPluginMetaData \
> too.
> To do it I followed the documentation and [this \
> post](http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/) about \
> KDE Frameworks 5 plugins by sebas.
>
> Diffs
> -----
>
> src/CMakeLists.txt 50f26be
> src/assistants/CMakeLists.txt 4baf622
> src/assistants/advancedplot/CMakeLists.txt 53da352
> src/assistants/advancedplot/advancedplotassistant.cpp a1a21ae
> src/assistants/advancedplot/advancedplotassistant.desktop 72b8c9c
> src/assistants/advancedplot/advancedplotassistant.json PRE-CREATION
> src/assistants/differentiate/CMakeLists.txt 3c722a1
> src/assistants/differentiate/differentiateassistant.cpp c8bafb1
> src/assistants/differentiate/differentiateassistant.desktop 58e9fb9
> src/assistants/differentiate/differentiateassistant.json PRE-CREATION
> src/assistants/importpackage/CMakeLists.txt 3db01e2
> src/assistants/importpackage/importpackageassistant.cpp e0a9b50
> src/assistants/importpackage/importpackageassistant.desktop efa9eed
> src/assistants/importpackage/importpackageassistant.json PRE-CREATION
> src/assistants/integrate/CMakeLists.txt 23d97fc
> src/assistants/integrate/integrateassistant.cpp 601c6b2
> src/assistants/integrate/integrateassistant.desktop fc2bfb3
> src/assistants/integrate/integrateassistant.json PRE-CREATION
> src/assistants/linearalgebra/creatematrix/CMakeLists.txt 8829d06
> src/assistants/linearalgebra/creatematrix/creatematrixassistant.cpp 3336604
> src/assistants/linearalgebra/creatematrix/creatematrixassistant.desktop 7baf665
> src/assistants/linearalgebra/creatematrix/creatematrixassistant.json PRE-CREATION
> src/assistants/linearalgebra/eigenvalues/CMakeLists.txt b487099
> src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.cpp e4f0cd9
> src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.desktop e7523c2
> src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.json PRE-CREATION
> src/assistants/linearalgebra/eigenvectors/CMakeLists.txt 4c6d086
> src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.cpp d8e02b2
> src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.desktop f0b8a28
> src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.json PRE-CREATION
> src/assistants/linearalgebra/invertmatrix/CMakeLists.txt 7e19591
> src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.cpp 9799c6d
> src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.desktop eaf1f52
> src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.json PRE-CREATION
> src/assistants/plot2d/CMakeLists.txt 2b02874
> src/assistants/plot2d/plot2dassistant.cpp 11d9db8
> src/assistants/plot2d/plot2dassistant.desktop 7a8c2da
> src/assistants/plot2d/plot2dassistant.json PRE-CREATION
> src/assistants/plot3d/CMakeLists.txt bbcac18
> src/assistants/plot3d/plot3dassistant.cpp 6b2e764
> src/assistants/plot3d/plot3dassistant.desktop c38e33c
> src/assistants/plot3d/plot3dassistant.json PRE-CREATION
> src/assistants/runscript/CMakeLists.txt 280a237
> src/assistants/runscript/runscriptassistant.cpp bb8147d
> src/assistants/runscript/runscriptassistant.desktop 0a89743
> src/assistants/runscript/runscriptassistant.json PRE-CREATION
> src/assistants/solve/CMakeLists.txt 2c25598
> src/assistants/solve/solveassistant.cpp 7ad1254
> src/assistants/solve/solveassistant.desktop 3b8de2e
> src/assistants/solve/solveassistant.json PRE-CREATION
> src/backends/CMakeLists.txt 2569d55
> src/backends/R/CMakeLists.txt 5e44b3c
> src/backends/R/rbackend.cpp a0d9e6a
> src/backends/R/rbackend.desktop a9ea1e1
> src/backends/R/rbackend.json PRE-CREATION
> src/backends/kalgebra/CMakeLists.txt 46a5440
> src/backends/kalgebra/kalgebrabackend.cpp 5d7fac9
> src/backends/kalgebra/kalgebrabackend.desktop f1a1b35
> src/backends/kalgebra/kalgebrabackend.json PRE-CREATION
> src/backends/lua/CMakeLists.txt 082f37b
> src/backends/lua/luabackend.cpp 30e258e
> src/backends/lua/luabackend.desktop 8ecd28e
> src/backends/lua/luabackend.json PRE-CREATION
> src/backends/maxima/CMakeLists.txt ca48d90
> src/backends/maxima/maximabackend.cpp 86843ef
> src/backends/maxima/maximabackend.desktop b1df2dd
> src/backends/maxima/maximabackend.json PRE-CREATION
> src/backends/null/CMakeLists.txt 69ffff3
> src/backends/null/nullbackend.cpp 602fd49
> src/backends/null/nullbackend.desktop 7f4be60
> src/backends/null/nullbackend.json PRE-CREATION
> src/backends/octave/CMakeLists.txt ee3ea92
> src/backends/octave/octavebackend.cpp 9842364
> src/backends/octave/octavebackend.desktop 3ef6332
> src/backends/octave/octavebackend.json PRE-CREATION
> src/backends/python2/CMakeLists.txt 02115ee
> src/backends/python2/python2backend.cpp 61662ff
> src/backends/python2/python2backend.desktop 4a60ea4
> src/backends/python2/python2backend.json PRE-CREATION
> src/backends/python3/CMakeLists.txt 6937480
> src/backends/python3/python3backend.cpp c83f631
> src/backends/python3/python3backend.desktop 05bce9d
> src/backends/python3/python3backend.json PRE-CREATION
> src/backends/qalculate/CMakeLists.txt e0f1c3a
> src/backends/qalculate/plotassistant/CMakeLists.txt efdd2d2
> src/backends/qalculate/plotassistant/qalculateplotassistant.cpp 1d0ae83
> src/backends/qalculate/plotassistant/qalculateplotassistant.desktop ce9901a
> src/backends/qalculate/plotassistant/qalculateplotassistant.json PRE-CREATION
> src/backends/qalculate/qalculatebackend.cpp da866ab
> src/backends/qalculate/qalculatebackend.desktop 14ecb8f
> src/backends/qalculate/qalculatebackend.json PRE-CREATION
> src/backends/sage/CMakeLists.txt 131ad07
> src/backends/sage/sagebackend.cpp b1a1ef5
> src/backends/sage/sagebackend.desktop 69d4f23
> src/backends/sage/sagebackend.json PRE-CREATION
> src/backends/scilab/CMakeLists.txt 4ce8200
> src/backends/scilab/scilabbackend.cpp 0d47595
> src/backends/scilab/scilabbackend.desktop 30f6edd
> src/backends/scilab/scilabbackend.json PRE-CREATION
> src/cantor_part.cpp 2e3d36d
> src/cantor_part.desktop 4619694
> src/cantor_part.json PRE-CREATION
> src/lib/CMakeLists.txt 9e33924
> src/lib/assistant.h f337591
> src/lib/assistant.cpp 60c521f
> src/lib/backend.cpp 5e64fe7
> src/lib/cantor_assistant.json PRE-CREATION
> src/lib/cantor_backend.json PRE-CREATION
> src/lib/cantor_panelplugin.json PRE-CREATION
> src/lib/panelplugin.h ebb02fe
> src/lib/panelplugin.cpp 1fa61d0
> src/lib/panelpluginhandler.cpp 8c73405
> src/panelplugins/CMakeLists.txt 6af7a48
> src/panelplugins/helppanel/CMakeLists.txt d8f785f
> src/panelplugins/helppanel/helppanelplugin.cpp 4611576
> src/panelplugins/helppanel/helppanelplugin.desktop fea19b6
> src/panelplugins/helppanel/helppanelplugin.json PRE-CREATION
> src/panelplugins/variablemgr/CMakeLists.txt 88f66d1
> src/panelplugins/variablemgr/variablemanagerplugin.cpp 6a7b448
> src/panelplugins/variablemgr/variablemanagerplugin.desktop e32f014
> src/panelplugins/variablemgr/variablemanagerplugin.json PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124168/diff/
>
>
> Testing
> -------
>
> * Build ok;
> * The plugins are loaded correctly;
> * Select some backend and see the Cantor loading assistants and panels;
> * Utilized some assistants, panels and backends, looks like correct.
>
>
> Thanks,
>
> Filipe Saraiva
>
>
--===============8557159291147601603==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124168/">https://git.reviewboard.kde.org/r/124168/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 3rd, 2015, 8:45 p.m. UTC, <b>Filipe \
Saraiva</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124168/diff/2/?file=382975#file382975line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">57</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">57</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">58</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">add_library</span><span class="p">(</span> <span \
class="s">cantorlibs</span> <span class="s">SHARED</span> <span \
class="o">${</span><span class="nv">cantor_LIB_SRCS</span><span class="o">}</span> \
<span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">58</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="nb">add_library</span><span \
class="p">(</span> <span class="s">cantorlibs</span> <span class="s">SHARED</span> \
<span class="o">${</span><span class="nv">cantor_LIB_SRCS</span><span \
class="o">}</span> <span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">59</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">59</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">60</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">kcoreaddons_desktop_to_json</span><span class="p">(</span><span \
class="s">cantorlibs</span> <span class="s">cantor_assistant.desktop</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">61</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">kcoreaddons_desktop_to_json</span><span class="p">(</span><span \
class="s">cantorlibs</span> <span class="s">cantor_backend.desktop</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">62</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">kcoreaddons_desktop_to_json</span><span class="p">(</span><span \
class="s">cantorlibs</span> <span class="s">cantor_panelplugin.desktop</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">63</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would like to get some tips about how to port that <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">kcoreaddons_desktop_to_json</em> to the new way.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How I \
change that <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">add_library</em> above? I get some error messages when \
I try to compile it.</p></pre> </blockquote>
<p>On July 4th, 2015, 4:30 p.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
doubt here is: is there anyway to use shared libraries with JSON metadata or we need \
to use .desktop files yet?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I master branch, src/lib/CMakeLists.txt \
has:</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: \
1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">install( FILES cantor_backend.desktop DESTINATION \
${KDE_INSTALL_KSERVICETYPES5DIR})</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">install( FILES \
cantor_assistant.desktop DESTINATION ${KDE_INSTALL_KSERVICETYPES5DIR})</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">install( FILES cantor_panelplugin.desktop DESTINATION \
${KDE_INSTALL_KSERVICETYPES5DIR})</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Must I change it for JSON files or I must to use \
.desktop files yet?</p></pre> </blockquote>
<p>On July 6th, 2015, 3:37 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
I've done in most occasions is just dropping the desktop files as the JSON gets \
embedded in the .so file.</p></pre> </blockquote>
<p>On July 12th, 2015, 3:26 a.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sune \
reply me in devel-mail list for not to use any metadata file. What do you think about \
it?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you don't need it, then you can get away without it. (That would be the \
case if you just want to load all plugins, and don't need to know anything about \
them, other than the libraryName.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If you do need any \
metadata, Aleix suggestion to use JSON is just fine (I'd recommend that). </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you really need KService and KSycoca (for backwards compatibility, for \
example), you'll have to use .desktop files (and convert them to json during build \
using kcoreaddons_desktop_to_json().</p></pre> <br />
<p>- Sebastian</p>
<br />
<p>On July 3rd, 2015, 8:33 p.m. UTC, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, and Sebastian \
Kügler.</div> <div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated July 3, 2015, 8:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is a new way to load plugins in KDE Frameworks 5 \
way. I ported Cantor plugins support to it. Now Cantor is using \
K_PLUGIN_FACTORY_WITH_JSON, the plugin path is the same of Qt5 ($QT_PLUGIN_PATH) and \
different types of Cantor plugins are installed in different subdirectories (backends \
in backends in ${KDE_INSTALL_PLUGINDIR}/cantor/backends, assistants in \
${KDE_INSTALL_PLUGINDIR}/cantor/assistants, and panels in \
${KDE_INSTALL_PLUGINDIR}/cantor/panels). KPluginInfo was changed to KPluginMetaData \
too.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To do it I followed the documentation and <a \
href="http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">this post</a> about KDE Frameworks 5 plugins by sebas.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The plugins are loaded correctly;</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Select some backend and \
see the Cantor loading assistants and panels;</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Utilized some assistants, panels and backends, looks like correct.</li> \
</ul></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(50f26be)</span></li>
<li>src/assistants/CMakeLists.txt <span style="color: grey">(4baf622)</span></li>
<li>src/assistants/advancedplot/CMakeLists.txt <span style="color: \
grey">(53da352)</span></li>
<li>src/assistants/advancedplot/advancedplotassistant.cpp <span style="color: \
grey">(a1a21ae)</span></li>
<li>src/assistants/advancedplot/advancedplotassistant.desktop <span style="color: \
grey">(72b8c9c)</span></li>
<li>src/assistants/advancedplot/advancedplotassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/differentiate/CMakeLists.txt <span style="color: \
grey">(3c722a1)</span></li>
<li>src/assistants/differentiate/differentiateassistant.cpp <span style="color: \
grey">(c8bafb1)</span></li>
<li>src/assistants/differentiate/differentiateassistant.desktop <span style="color: \
grey">(58e9fb9)</span></li>
<li>src/assistants/differentiate/differentiateassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/importpackage/CMakeLists.txt <span style="color: \
grey">(3db01e2)</span></li>
<li>src/assistants/importpackage/importpackageassistant.cpp <span style="color: \
grey">(e0a9b50)</span></li>
<li>src/assistants/importpackage/importpackageassistant.desktop <span style="color: \
grey">(efa9eed)</span></li>
<li>src/assistants/importpackage/importpackageassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/integrate/CMakeLists.txt <span style="color: \
grey">(23d97fc)</span></li>
<li>src/assistants/integrate/integrateassistant.cpp <span style="color: \
grey">(601c6b2)</span></li>
<li>src/assistants/integrate/integrateassistant.desktop <span style="color: \
grey">(fc2bfb3)</span></li>
<li>src/assistants/integrate/integrateassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/linearalgebra/creatematrix/CMakeLists.txt <span style="color: \
grey">(8829d06)</span></li>
<li>src/assistants/linearalgebra/creatematrix/creatematrixassistant.cpp <span \
style="color: grey">(3336604)</span></li>
<li>src/assistants/linearalgebra/creatematrix/creatematrixassistant.desktop <span \
style="color: grey">(7baf665)</span></li>
<li>src/assistants/linearalgebra/creatematrix/creatematrixassistant.json <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/CMakeLists.txt <span style="color: \
grey">(b487099)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.cpp <span \
style="color: grey">(e4f0cd9)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.desktop <span \
style="color: grey">(e7523c2)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.json <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/CMakeLists.txt <span style="color: \
grey">(4c6d086)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.cpp <span \
style="color: grey">(d8e02b2)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.desktop <span \
style="color: grey">(f0b8a28)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.json <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/CMakeLists.txt <span style="color: \
grey">(7e19591)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.cpp <span \
style="color: grey">(9799c6d)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.desktop <span \
style="color: grey">(eaf1f52)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.json <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/assistants/plot2d/CMakeLists.txt <span style="color: \
grey">(2b02874)</span></li>
<li>src/assistants/plot2d/plot2dassistant.cpp <span style="color: \
grey">(11d9db8)</span></li>
<li>src/assistants/plot2d/plot2dassistant.desktop <span style="color: \
grey">(7a8c2da)</span></li>
<li>src/assistants/plot2d/plot2dassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/plot3d/CMakeLists.txt <span style="color: \
grey">(bbcac18)</span></li>
<li>src/assistants/plot3d/plot3dassistant.cpp <span style="color: \
grey">(6b2e764)</span></li>
<li>src/assistants/plot3d/plot3dassistant.desktop <span style="color: \
grey">(c38e33c)</span></li>
<li>src/assistants/plot3d/plot3dassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/runscript/CMakeLists.txt <span style="color: \
grey">(280a237)</span></li>
<li>src/assistants/runscript/runscriptassistant.cpp <span style="color: \
grey">(bb8147d)</span></li>
<li>src/assistants/runscript/runscriptassistant.desktop <span style="color: \
grey">(0a89743)</span></li>
<li>src/assistants/runscript/runscriptassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/assistants/solve/CMakeLists.txt <span style="color: \
grey">(2c25598)</span></li>
<li>src/assistants/solve/solveassistant.cpp <span style="color: \
grey">(7ad1254)</span></li>
<li>src/assistants/solve/solveassistant.desktop <span style="color: \
grey">(3b8de2e)</span></li>
<li>src/assistants/solve/solveassistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(2569d55)</span></li>
<li>src/backends/R/CMakeLists.txt <span style="color: grey">(5e44b3c)</span></li>
<li>src/backends/R/rbackend.cpp <span style="color: grey">(a0d9e6a)</span></li>
<li>src/backends/R/rbackend.desktop <span style="color: grey">(a9ea1e1)</span></li>
<li>src/backends/R/rbackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/kalgebra/CMakeLists.txt <span style="color: \
grey">(46a5440)</span></li>
<li>src/backends/kalgebra/kalgebrabackend.cpp <span style="color: \
grey">(5d7fac9)</span></li>
<li>src/backends/kalgebra/kalgebrabackend.desktop <span style="color: \
grey">(f1a1b35)</span></li>
<li>src/backends/kalgebra/kalgebrabackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/CMakeLists.txt <span style="color: grey">(082f37b)</span></li>
<li>src/backends/lua/luabackend.cpp <span style="color: grey">(30e258e)</span></li>
<li>src/backends/lua/luabackend.desktop <span style="color: \
grey">(8ecd28e)</span></li>
<li>src/backends/lua/luabackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/maxima/CMakeLists.txt <span style="color: \
grey">(ca48d90)</span></li>
<li>src/backends/maxima/maximabackend.cpp <span style="color: \
grey">(86843ef)</span></li>
<li>src/backends/maxima/maximabackend.desktop <span style="color: \
grey">(b1df2dd)</span></li>
<li>src/backends/maxima/maximabackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/null/CMakeLists.txt <span style="color: grey">(69ffff3)</span></li>
<li>src/backends/null/nullbackend.cpp <span style="color: \
grey">(602fd49)</span></li>
<li>src/backends/null/nullbackend.desktop <span style="color: \
grey">(7f4be60)</span></li>
<li>src/backends/null/nullbackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/octave/CMakeLists.txt <span style="color: \
grey">(ee3ea92)</span></li>
<li>src/backends/octave/octavebackend.cpp <span style="color: \
grey">(9842364)</span></li>
<li>src/backends/octave/octavebackend.desktop <span style="color: \
grey">(3ef6332)</span></li>
<li>src/backends/octave/octavebackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/python2/CMakeLists.txt <span style="color: \
grey">(02115ee)</span></li>
<li>src/backends/python2/python2backend.cpp <span style="color: \
grey">(61662ff)</span></li>
<li>src/backends/python2/python2backend.desktop <span style="color: \
grey">(4a60ea4)</span></li>
<li>src/backends/python2/python2backend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/CMakeLists.txt <span style="color: \
grey">(6937480)</span></li>
<li>src/backends/python3/python3backend.cpp <span style="color: \
grey">(c83f631)</span></li>
<li>src/backends/python3/python3backend.desktop <span style="color: \
grey">(05bce9d)</span></li>
<li>src/backends/python3/python3backend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/qalculate/CMakeLists.txt <span style="color: \
grey">(e0f1c3a)</span></li>
<li>src/backends/qalculate/plotassistant/CMakeLists.txt <span style="color: \
grey">(efdd2d2)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotassistant.cpp <span \
style="color: grey">(1d0ae83)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotassistant.desktop <span \
style="color: grey">(ce9901a)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotassistant.json <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/qalculate/qalculatebackend.cpp <span style="color: \
grey">(da866ab)</span></li>
<li>src/backends/qalculate/qalculatebackend.desktop <span style="color: \
grey">(14ecb8f)</span></li>
<li>src/backends/qalculate/qalculatebackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/sage/CMakeLists.txt <span style="color: grey">(131ad07)</span></li>
<li>src/backends/sage/sagebackend.cpp <span style="color: \
grey">(b1a1ef5)</span></li>
<li>src/backends/sage/sagebackend.desktop <span style="color: \
grey">(69d4f23)</span></li>
<li>src/backends/sage/sagebackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backends/scilab/CMakeLists.txt <span style="color: \
grey">(4ce8200)</span></li>
<li>src/backends/scilab/scilabbackend.cpp <span style="color: \
grey">(0d47595)</span></li>
<li>src/backends/scilab/scilabbackend.desktop <span style="color: \
grey">(30f6edd)</span></li>
<li>src/backends/scilab/scilabbackend.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/cantor_part.cpp <span style="color: grey">(2e3d36d)</span></li>
<li>src/cantor_part.desktop <span style="color: grey">(4619694)</span></li>
<li>src/cantor_part.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(9e33924)</span></li>
<li>src/lib/assistant.h <span style="color: grey">(f337591)</span></li>
<li>src/lib/assistant.cpp <span style="color: grey">(60c521f)</span></li>
<li>src/lib/backend.cpp <span style="color: grey">(5e64fe7)</span></li>
<li>src/lib/cantor_assistant.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/lib/cantor_backend.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/cantor_panelplugin.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/lib/panelplugin.h <span style="color: grey">(ebb02fe)</span></li>
<li>src/lib/panelplugin.cpp <span style="color: grey">(1fa61d0)</span></li>
<li>src/lib/panelpluginhandler.cpp <span style="color: grey">(8c73405)</span></li>
<li>src/panelplugins/CMakeLists.txt <span style="color: grey">(6af7a48)</span></li>
<li>src/panelplugins/helppanel/CMakeLists.txt <span style="color: \
grey">(d8f785f)</span></li>
<li>src/panelplugins/helppanel/helppanelplugin.cpp <span style="color: \
grey">(4611576)</span></li>
<li>src/panelplugins/helppanel/helppanelplugin.desktop <span style="color: \
grey">(fea19b6)</span></li>
<li>src/panelplugins/helppanel/helppanelplugin.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/panelplugins/variablemgr/CMakeLists.txt <span style="color: \
grey">(88f66d1)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerplugin.cpp <span style="color: \
grey">(6a7b448)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerplugin.desktop <span style="color: \
grey">(e32f014)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerplugin.json <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124168/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8557159291147601603==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic