'Re: Review Request 124040: Fix "close" button in tabbar after porting from KTabWidget to QTabWidget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 124040: Fix "close" button in tabbar after porting from KTabWidget to QTabWidget
From:       "Alexander Potashev" <aspotashev () gmail ! com>
Date:       2015-06-20 16:45:26
Message-ID: 20150620164526.23529.70730 () mimi ! kde ! org
[Download RAW message or body]

--===============8112967731559853728==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124040/
-----------------------------------------------------------

(Updated June 20, 2015, 4:45 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, Lucas Hermann Negri, and Minh \
Ngo.

Changes
-------

Submitted with commit eb9e238fe676ce2337981fb1de4d79cc2f3ba034 by Alexander Potashev to branch \
master.

Repository: cantor

Description
-------

Use signal QTabWidget::tabCloseRequested(int) instead of
KTabWidget::closeRequest(QWidget*).

Problem introduced by commit 8711f0596f03658de1627a2862c1893cb766e8bc
"Port KTabWidget to QTabWidget", review request 123966.

Diffs
-----

  src/cantor.h 2c12b3d0b0ceec35967eee1efb7afa372282c6d2 
  src/cantor.cpp 02c6cf3d8fcc73f2d8fe86819a56269682effe21 

Diff: https://git.reviewboard.kde.org/r/124040/diff/

Testing
-------

Closing tabs works by clicking on the "x" button in the tabbar and by clicking "File -> Close".

Thanks,

Alexander Potashev

--===============8112967731559853728==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124040/">https://git.reviewboard.kde.org/r/124040/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, Lucas Hermann Negri, and \
Minh Ngo.</div> <div>By Alexander Potashev.</div>

<p style="color: grey;"><i>Updated June 20, 2015, 4:45 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
eb9e238fe676ce2337981fb1de4d79cc2f3ba034 by Alexander Potashev to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use signal \
QTabWidget::tabCloseRequested(int) instead of KTabWidget::closeRequest(QWidget*).

Problem introduced by commit 8711f0596f03658de1627a2862c1893cb766e8bc
&quot;Port KTabWidget to QTabWidget&quot;, review request 123966.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Closing tabs \
works by clicking on the "x" button in the tabbar and by clicking "File -&gt; Close".</p></pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/cantor.h <span style="color: \
grey">(2c12b3d0b0ceec35967eee1efb7afa372282c6d2)</span></li>

 <li>src/cantor.cpp <span style="color: \
grey">(02c6cf3d8fcc73f2d8fe86819a56269682effe21)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124040/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8112967731559853728==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 