'Re: Review Request 123919: Move the Option to Save with Backend Extension to "Save As Plaintext"'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 123919: Move the Option to Save with Backend Extension to "Save As Plaintext"
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-06-14 6:53:08
Message-ID: 20150614065308.15191.70862 () mimi ! kde ! org
[Download RAW message or body]

--===============7654870749451427669==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On June 3, 2015, 1:43 p.m., Filipe Saraiva wrote:
> > I would like to see this feature working yet. I don't know if remove the feature \
> > is the best for it. I will talk with Alex Rieder (the official Cantor maintainer) \
> > about it. 
> > Thanks!
> 
> Filipe Saraiva wrote:
> Can you try to fix the feature? =)
> 
> David Narváez wrote:
> The only thing a backend's script extension provides to the CantorPart is a script \
> *filter* so in order for CantorPart to know whether the user selected a filename \
> ending on the script *file extension* we would have to parse the filter to extract \
> the actual file extension and then check with QString::endsWith. 
> I think that's doable but the code is really ugly and it is all because this \
> feature was not thought for saving scripts. Save as Plaintext, on the other hand, \
> does precisely that, so I really think we should move this from Save As. 
> Alexander Rieder wrote:
> Hi,
> after having a look at this, I think the best way to not confuse any user might be \
>                 to do the following:
> - disable the feature for the current stable release, as it is clearly broken
> - for future releases i think we should try to detect if the user wants to save as \
> script file, by simply checking if it ends in ".cws" or not. If the user selected a \
> different ending Cantor should give a warning that all formatting/results will not \
> be saved. If the user accepts, then we should save to plain, if not we should show \
> the file dialog again with the ending changed to .cws. 
> what do you think? David, can you implement something like this?
> 
> best regards,
> Alexander

I am confused: what feature are you refering to? For me, there's the Save feature to \
save a Cantor worksheet, and a Save as Plaintext feature to save a script, and the \
code is just in the wrong place.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123919/#review81123
-----------------------------------------------------------

On May 27, 2015, 11:48 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123919/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 11:48 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 348338
> http://bugs.kde.org/show_bug.cgi?id=348338
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The "Save (As)" options do not know of anything but Cantor worksheets so
> it is better to move saving as a script to the "Save As Plaintext"
> option.
> 
> 
> Diffs
> -----
> 
> src/cantor_part.cpp 84a7ca96dfae836717240e2377b02656aa4b8999 
> 
> Diff: https://git.reviewboard.kde.org/r/123919/diff/
> 
> 
> Testing
> -------
> 
> See steps to reproduce bug 348338.
> 
> 
> Thanks,
> 
> David Narváez
> 
> 

--===============7654870749451427669==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123919/">https://git.reviewboard.kde.org/r/123919/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 3rd, 2015, 1:43 p.m. UTC, <b>Filipe \
Saraiva</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I would like to see this feature working yet. I don't \
know if remove the feature is the best for it. I will talk with Alex Rieder (the \
official Cantor maintainer) about it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks!</p></pre>  \
</blockquote>

 <p>On June 3rd, 2015, 1:48 p.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can \
you try to fix the feature? =)</p></pre>  </blockquote>

 <p>On June 3rd, 2015, 2:27 p.m. UTC, <b>David Narváez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
only thing a backend's script extension provides to the CantorPart is a script <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">filter</em> so in order for CantorPart to know whether the user selected a \
filename ending on the script <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">file extension</em> we would have to \
parse the filter to extract the actual file extension and then check with \
QString::endsWith.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I think that's doable but the code is \
really ugly and it is all because this feature was not thought for saving scripts. \
Save as Plaintext, on the other hand, does precisely that, so I really think we \
should move this from Save As.</p></pre>  </blockquote>

 <p>On June 10th, 2015, 3:55 p.m. UTC, <b>Alexander Rieder</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, \
after having a look at this, I think the best way to not confuse any user might be to \
                do the following:
- disable the feature for the current stable release, as it is clearly broken
- for future releases i think we should try to detect if the user wants to save as \
script file, by simply checking if it ends in ".cws" or not. If the user selected a \
different ending Cantor should give a warning that all formatting/results will not be \
saved. If the user accepts, then we should save to plain, if not we should show the \
file dialog again with the ending changed to .cws.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what \
do you think? David, can you implement something like this?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">best \
regards, Alexander</p></pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am \
confused: what feature are you refering to? For me, there's the Save feature to save \
a Cantor worksheet, and a Save as Plaintext feature to save a script, and the code is \
just in the wrong place.</p></pre> <br />

<p>- David</p>

<br />
<p>On May 27th, 2015, 11:48 p.m. UTC, David Narváez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated May 27, 2015, 11:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=348338">348338</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The &quot;Save (As)&quot; options do not know of anything but Cantor \
worksheets so it is better to move saving as a script to the &quot;Save As \
Plaintext&quot; option.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See steps to reproduce bug 348338.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/cantor_part.cpp <span style="color: \
grey">(84a7ca96dfae836717240e2377b02656aa4b8999)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123919/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7654870749451427669==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 