[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 124040: CantorShell: Port away from KTabWidget's signal closeRequest(QWidget*)
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2015-06-08 14:13:10
Message-ID: 20150608141310.2486.14317 () mimi ! kde ! org
[Download RAW message or body]
--===============2065441727857837972==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124040/#review81312
-----------------------------------------------------------
You are not saying why you did the change...
- Aleix Pol Gonzalez
On June 8, 2015, 1:13 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124040/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 1:13 p.m.)
>
>
> Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, Lucas Hermann Negri, \
> and Minh Ngo.
>
> Repository: cantor
>
>
> Description
> -------
>
> Use signal QTabWidget::tabCloseRequested(int) instead.
>
>
> Diffs
> -----
>
> src/cantor.h 2c12b3d0b0ceec35967eee1efb7afa372282c6d2
> src/cantor.cpp 02c6cf3d8fcc73f2d8fe86819a56269682effe21
>
> Diff: https://git.reviewboard.kde.org/r/124040/diff/
>
>
> Testing
> -------
>
> Closing tabs works by clicking on the "x" button in the tabbar and by clicking \
> "File -> Close".
>
> Thanks,
>
> Alexander Potashev
>
>
--===============2065441727857837972==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124040/">https://git.reviewboard.kde.org/r/124040/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
are not saying why you did the change...</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 8th, 2015, 1:13 p.m. CEST, Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, Lucas Hermann \
Negri, and Minh Ngo.</div> <div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated June 8, 2015, 1:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use signal QTabWidget::tabCloseRequested(int) instead.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Closing tabs works by clicking on the "x" button in \
the tabbar and by clicking "File -> Close".</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/cantor.h <span style="color: \
grey">(2c12b3d0b0ceec35967eee1efb7afa372282c6d2)</span></li>
<li>src/cantor.cpp <span style="color: \
grey">(02c6cf3d8fcc73f2d8fe86819a56269682effe21)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124040/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2065441727857837972==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic