'Re: Review Request 124010: [Cantor] Port KFileDialog to QFileDialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 124010: [Cantor] Port KFileDialog to QFileDialog
From:       "Filipe Saraiva" <filipe () kde ! org>
Date:       2015-06-06 18:27:10
Message-ID: 20150606182710.8350.19176 () mimi ! kde ! org
[Download RAW message or body]

--===============8475019918186471407==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124010/
-----------------------------------------------------------

(Updated June 6, 2015, 6:27 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Aleix Pol Gonzalez and Alexander Rieder.

Changes
-------

Submitted with commit 44c27655140b1a0ae544892f8332e900b95d4aa5 by Filipe Saraiva to \
branch master.

Repository: cantor

Description
-------

KFileDialog is deprecated for KF5. The library was ported to QFileDialog. Some \
changes in QFileDialog filters were performed in *extensions.cpp files.

Diffs
-----

  src/assistants/runscript/runscriptassistant.cpp fb07f15 
  src/backends/R/rextensions.cpp c4e6cba 
  src/backends/lua/luaextensions.cpp bf522bb 
  src/backends/maxima/maximaextensions.cpp c36cc75 
  src/backends/octave/octaveextensions.cpp 55e3eca 
  src/backends/python/pythonextensions.cpp f13d662 
  src/backends/sage/sageextensions.cpp 022630c 
  src/backends/scilab/scilabextensions.cpp bd04edf 
  src/scripteditorwidget.cpp ff3530e 

Diff: https://git.reviewboard.kde.org/r/124010/diff/

Testing
-------

* Build ok;
* The filters are working properly.

Thanks,

Filipe Saraiva

--===============8475019918186471407==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124010/">https://git.reviewboard.kde.org/r/124010/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Aleix Pol Gonzalez and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated June 6, 2015, 6:27 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 44c27655140b1a0ae544892f8332e900b95d4aa5 by Filipe \
Saraiva to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KFileDialog is deprecated for KF5. The library was \
ported to QFileDialog. Some changes in QFileDialog filters were performed in \
*extensions.cpp files.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The filters are working properly.</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/assistants/runscript/runscriptassistant.cpp <span style="color: \
grey">(fb07f15)</span></li>

 <li>src/backends/R/rextensions.cpp <span style="color: grey">(c4e6cba)</span></li>

 <li>src/backends/lua/luaextensions.cpp <span style="color: \
grey">(bf522bb)</span></li>

 <li>src/backends/maxima/maximaextensions.cpp <span style="color: \
grey">(c36cc75)</span></li>

 <li>src/backends/octave/octaveextensions.cpp <span style="color: \
grey">(55e3eca)</span></li>

 <li>src/backends/python/pythonextensions.cpp <span style="color: \
grey">(f13d662)</span></li>

 <li>src/backends/sage/sageextensions.cpp <span style="color: \
grey">(022630c)</span></li>

 <li>src/backends/scilab/scilabextensions.cpp <span style="color: \
grey">(bd04edf)</span></li>

 <li>src/scripteditorwidget.cpp <span style="color: grey">(ff3530e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124010/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8475019918186471407==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 