'Re: Review Request 123966: Port KPushButton to QPushButton'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 123966: Port KPushButton to QPushButton
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2015-05-31 22:12:50
Message-ID: 20150531221250.8350.16666 () mimi ! kde ! org
[Download RAW message or body]

--===============4865936042252983244==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123966/#review81024
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On May 31, 2015, 6:06 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123966/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 6:06 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KPushButton is deprecated in KF5. [Documentation \
> page](http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKPushButton.html) \
> suggests to port it to QPushButton. 
> 
> Diffs
> -----
> 
> src/backends/qalculate/plotassistant/qalculateplotdialog.ui e77fe06 
> src/imagesettings.ui 224e1a2 
> src/imagesettingsdialog.cpp d318f7a 
> 
> Diff: https://git.reviewboard.kde.org/r/123966/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * Plot created correctly in Qalculate backend;
> * Add image to worksheet working correctly.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
> 

--===============4865936042252983244==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123966/">https://git.reviewboard.kde.org/r/123966/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On May 31st, 2015, 6:06 p.m. CEST, Filipe Saraiva wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh \
Ngo.</div> <div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated May 31, 2015, 6:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KPushButton is deprecated in KF5. <a \
href="http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKPushButton.html" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Documentation page</a> suggests to port it to QPushButton.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Plot created correctly in Qalculate backend;</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Add \
image to worksheet working correctly.</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/qalculate/plotassistant/qalculateplotdialog.ui <span style="color: \
grey">(e77fe06)</span></li>

 <li>src/imagesettings.ui <span style="color: grey">(224e1a2)</span></li>

 <li>src/imagesettingsdialog.cpp <span style="color: grey">(d318f7a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123966/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4865936042252983244==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 