'Re: Review Request 123531: Build Cantor with the R backend also when the R version is equal or highe'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 123531: Build Cantor with the R backend also when the R version is equal or highe
From:       "Raymond Wooninck" <tittiatcoke () gmail ! com>
Date:       2015-05-25 13:20:55
Message-ID: 20150525132055.17589.63229 () mimi ! kde ! org
[Download RAW message or body]

--===============7451906595653420988==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123531/
-----------------------------------------------------------

(Updated May 25, 2015, 1:20 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.

Changes
-------

Submitted with commit 88b14d85b9504af29fa34ac41109db6ff1d8bdf5 by Raymond Wooninck to \
branch master.

Repository: cantor

Description
-------

In this commit:
https://github.com/wch/r-source/commit/c67a107dd7b0f074cec9359b8e2ca07c6243283c

R_running_as_main_program was moved from Rmain.c to Rinterface.h, and lost
its 'extern' declaration. This change is now causing linker problems when trying to \
build cantor against R v3.2 :

[  391s] CMakeFiles/cantor_rserver.dir/rcallbacks.o:(.bss+0x10): multiple definition \
of `R_running_as_main_program' [  391s] \
CMakeFiles/cantor_rserver.dir/rserver.o:(.bss+0x0): first defined here [  391s] \
collect2: error: ld returned 1 exit status [  391s] \
src/backends/R/rserver/CMakeFiles/cantor_rserver.dir/build.make:247: recipe for \
target 'src/backends/R/rserver/cantor_rserver' failed [  391s] make[2]: *** \
[src/backends/R/rserver/cantor_rserver] Error 1

The attached patch would resolve the multiple definition.

Diffs
-----

  src/backends/R/rserver/rcallbacks.h 8f4752c 
  src/backends/R/rserver/rcallbacks.cpp 2c86531 
  src/backends/R/rserver/rserver.cpp 30cdb70 

Diff: https://git.reviewboard.kde.org/r/123531/diff/

Testing
-------

Cantor builds fine for R v3.1.1 and R v3.2 versions

Thanks,

Raymond Wooninck

--===============7451906595653420988==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123531/">https://git.reviewboard.kde.org/r/123531/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Raymond Wooninck.</div>

<p style="color: grey;"><i>Updated May 25, 2015, 1:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 88b14d85b9504af29fa34ac41109db6ff1d8bdf5 by \
Raymond Wooninck to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In this commit: \
https://github.com/wch/r-source/commit/c67a107dd7b0f074cec9359b8e2ca07c6243283c</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">R_running_as_main_program was moved from Rmain.c to \
Rinterface.h, and lost its 'extern' declaration. This change is now causing linker \
problems when trying to build cantor against R v3.2 :</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[  \
391s] CMakeFiles/cantor_rserver.dir/rcallbacks.o:(.bss+0x10): multiple definition of \
`R_running_as_main_program' [  391s] \
CMakeFiles/cantor_rserver.dir/rserver.o:(.bss+0x0): first defined here [  391s] \
collect2: error: ld returned 1 exit status [  391s] \
src/backends/R/rserver/CMakeFiles/cantor_rserver.dir/build.make:247: recipe for \
target 'src/backends/R/rserver/cantor_rserver' failed [  391s] make[2]: *** \
[src/backends/R/rserver/cantor_rserver] Error 1</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
attached patch would resolve the multiple definition.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Cantor builds fine for R v3.1.1 and R v3.2 \
versions</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/R/rserver/rcallbacks.h <span style="color: \
grey">(8f4752c)</span></li>

 <li>src/backends/R/rserver/rcallbacks.cpp <span style="color: \
grey">(2c86531)</span></li>

 <li>src/backends/R/rserver/rserver.cpp <span style="color: \
grey">(30cdb70)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123531/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7451906595653420988==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 