[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 123840: Port KDoubleNumInput to QDoubleSpinBox
From: "Filipe Saraiva" <filipe () kde ! org>
Date: 2015-05-19 14:44:24
Message-ID: 20150519144424.16315.28964 () mimi ! kde ! org
[Download RAW message or body]
--===============0363314411687928160==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123840/
-----------------------------------------------------------
(Updated May 19, 2015, 2:44 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh \
Ngo.
Changes
-------
Submitted with commit be18cfebea581418077981dc236a51e620449c27 by Filipe \
Saraiva to branch master.
Repository: cantor
Description
-------
KDoubleNumInput is deprecated for KF5. The \
[documentation](http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKDoubleNumInput.html) \
recommends to change for QSpinBox, but there is a \
[QDoubleSpinBox](http://doc.qt.io/qt-5/qdoublespinbox.html) class more \
close to KDoubleNumInput. Maybe is it an error on KDELibs4Support \
documentation?
Diffs
-----
src/imagesettings.ui 13b7f97
Diff: https://git.reviewboard.kde.org/r/123840/diff/
Testing
-------
* Build ok;
* I can to load an image on worksheet correctly (Mouse button 2 on \
worksheet > Insert > Image; button 2 to load image > select some image > \
change the values presented > Ok).
Thanks,
Filipe Saraiva
--===============0363314411687928160==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123840/">https://git.reviewboard.kde.org/r/123840/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and \
Minh Ngo.</div> <div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated May 19, 2015, 2:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit be18cfebea581418077981dc236a51e620449c27 \
by Filipe Saraiva to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KDoubleNumInput is deprecated \
for KF5. The <a href="http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKDoubleNumInput.html" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">documentation</a> recommends to change for \
QSpinBox, but there is a <a \
href="http://doc.qt.io/qt-5/qdoublespinbox.html" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">QDoubleSpinBox</a> class more close to KDoubleNumInput. Maybe is \
it an error on KDELibs4Support documentation?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Build ok;</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">I can to load \
an image on worksheet correctly (Mouse button 2 on worksheet > Insert \
> Image; button 2 to load image > select some image > change the \
values presented > Ok).</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/imagesettings.ui <span style="color: grey">(13b7f97)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123840/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0363314411687928160==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic