[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 123725: [Cantor] Port from KTabWidget to QTabWidget
From: "Filipe Saraiva" <filipe () kde ! org>
Date: 2015-05-16 20:09:20
Message-ID: 20150516200920.8613.68227 () mimi ! kde ! org
[Download RAW message or body]
--===============2779085883202234021==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123725/
-----------------------------------------------------------
(Updated May 16, 2015, 8:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
Changes
-------
Submitted with commit 8711f0596f03658de1627a2862c1893cb766e8bc by Filipe Saraiva to \
branch master.
Repository: cantor
Description
-------
KTabWidget is deprecated (it is part of KDELibs4Support) and must to be ported to \
QTabWidget.
The patch replaces all uses of KTabWidget for QTabWidget.
Diffs
-----
src/assistants/advancedplot/advancedplotdialog.ui 7aa31a8
src/backends/qalculate/plotassistant/qalculateplotdialog.ui 6da4a79
src/backends/qalculate/settings.ui f0baddf
src/cantor.h b675e35
src/cantor.cpp 78dad16
Diff: https://git.reviewboard.kde.org/r/123725/diff/
Testing
-------
* Build ok;
* Created new worksheet (new tab) ok;
* Open worksheet, ok;
* Two worksheets opened in the same time, ok.
Thanks,
Filipe Saraiva
--===============2779085883202234021==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123725/">https://git.reviewboard.kde.org/r/123725/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh \
Ngo.</div> <div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated May 16, 2015, 8:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8711f0596f03658de1627a2862c1893cb766e8bc by Filipe \
Saraiva to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KTabWidget is deprecated (it is part of \
KDELibs4Support) and must to be ported to QTabWidget.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
patch replaces all uses of KTabWidget for QTabWidget.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Created new worksheet (new tab) ok;</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Open \
worksheet, ok;</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Two worksheets opened in the same time, \
ok.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/assistants/advancedplot/advancedplotdialog.ui <span style="color: \
grey">(7aa31a8)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotdialog.ui <span style="color: \
grey">(6da4a79)</span></li>
<li>src/backends/qalculate/settings.ui <span style="color: \
grey">(f0baddf)</span></li>
<li>src/cantor.h <span style="color: grey">(b675e35)</span></li>
<li>src/cantor.cpp <span style="color: grey">(78dad16)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123725/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2779085883202234021==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic