'Re: Review Request 122855: image the same for all translations of the item'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 122855: image the same for all translations of the item
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2015-03-22 23:07:21
Message-ID: 20150322230721.548.73840 () mimi ! kde ! org
[Download RAW message or body]

--===============5183971971631822469==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 16, 2015, 1:40 a.m., Inge Wallin wrote:
> > That bug is about it not being possible to remove the image due to some side \
> > effects from how the image is stored in the document.  Does this patch solve that \
> > problem? As far as I can see it does not.  Any solution to the problem has to be \
> > in the keduvocdocument library and not inside parley.

Adding a comment to help Ben Cooksley with mail headers from the reviewboard.  Sorry \
to hijack this thread, you can safely ignore this comment.

- Inge

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122855/#review77540
-----------------------------------------------------------

On March 8, 2015, 10:01 a.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122855/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 10:01 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> it always keeps the image same for all translations of the item,solution of \
> "https://bugs.kde.org/show_bug.cgi?id=263836" 
> 
> Diffs
> -----
> 
> src/editor/imagechooserwidget.cpp 8ad5f3d 
> 
> Diff: https://git.reviewboard.kde.org/r/122855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
> 

--===============5183971971631822469==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122855/">https://git.reviewboard.kde.org/r/122855/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 16th, 2015, 1:40 a.m. CET, <b>Inge \
Wallin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">That bug is about it not being possible to remove the \
image due to some side effects from how the image is stored in the document.  Does \
this patch solve that problem? As far as I can see it does not.  Any solution to the \
problem has to be in the keduvocdocument library and not inside parley.</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Adding a comment to help Ben Cooksley with mail headers from the \
reviewboard.  Sorry to hijack this thread, you can safely ignore this \
comment.</p></pre> <br />

<p>- Inge</p>

<br />
<p>On March 8th, 2015, 10:01 a.m. CET, ankit wagadre wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By ankit wagadre.</div>

<p style="color: grey;"><i>Updated March 8, 2015, 10:01 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">it always keeps the image same for all translations of \
the item,solution of "https://bugs.kde.org/show_bug.cgi?id=263836"</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/editor/imagechooserwidget.cpp <span style="color: \
grey">(8ad5f3d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122855/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5183971971631822469==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 