From kde-edu-devel  Fri Mar 20 12:42:58 2015
From: Garvit Khatri <garvitdelhi () gmail ! com>
Date: Fri, 20 Mar 2015 12:42:58 +0000
To: kde-edu-devel
Subject: Re: LabPlot builds and runs with kf5
Message-Id: <CAE_LK91GzZbWLrshE5kX=6e_oAitR9PcrjWdDBEFP7oGy5y=bA () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=142685479408217
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============7864648326730302228=="

--===============7864648326730302228==
Content-Type: multipart/alternative; boundary=001a11c3556a14a21e0511b77d1e

--001a11c3556a14a21e0511b77d1e
Content-Type: text/plain; charset=UTF-8

On Fri, Mar 20, 2015 at 12:41 PM, Alexander Semke <Alexander.Semke@web.de>
wrote:

> Hi Garrit,
>
> > I have merged master commits to frameworks branch and after QIcon fix
> > everything looks fine to me. I am able to plot graphs with mathematical
> > equations and also from spreadsheets. I have applied a QIcon fix which
> > fixes the icon problem and everything looks fine to me and we can merge
> > framework with master and continue development on KF5.
> I want to release the next version of labplot first. After that we can
> decide
> what to do with master and frameworks.
>
> What do you mean with QIcon fix? The icons were not shown on your system.
> What
> was the fix for that?
>
I didn't implemented QIcon correctly for Qt5 that is why icons were not
shown, now all the icons are shown correctly after this fix.

-- 
Cheers,
Garvit Khatri

--001a11c3556a14a21e0511b77d1e
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Fri, Mar 20, 2015 at 12:41 PM, Alexander Semke <span dir=3D"ltr">&lt=
;<a href=3D"mailto:Alexander.Semke@web.de" target=3D"_blank">Alexander.Semk=
e@web.de</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Garri=
t,<br>
<span class=3D""><br>
&gt; I have merged master commits to frameworks branch and after QIcon fix<=
br>
&gt; everything looks fine to me. I am able to plot graphs with mathematica=
l<br>
&gt; equations and also from spreadsheets. I have applied a QIcon fix which=
<br>
&gt; fixes the icon problem and everything looks fine to me and we can merg=
e<br>
&gt; framework with master and continue development on KF5.<br>
</span>I want to release the next version of labplot first. After that we c=
an decide<br>
what to do with master and frameworks.<br>
<br>
What do you mean with QIcon fix? The icons were not shown on your system. W=
hat<br>
was the fix for that?<br></blockquote><div>I didn&#39;t implemented QIcon c=
orrectly for Qt5 that is why icons were not shown, now all the icons are sh=
own correctly after this fix.<br></div></div><br>-- <br><div class=3D"gmail=
_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div di=
r=3D"ltr"><span style=3D"font-size:12.8000001907349px">Cheers</span>,<br>Ga=
rvit Khatri</div></div></div></div></div></div>
</div></div>

--001a11c3556a14a21e0511b77d1e--

--===============7864648326730302228==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2RlLWVkdSBt
YWlsaW5nIGxpc3QKa2RlLWVkdUBtYWlsLmtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtkZS5vcmcvbWFp
bG1hbi9saXN0aW5mby9rZGUtZWR1Cg==

--===============7864648326730302228==--