'Review Request 122344: Define a Proper PointStyle Enum Across Kig'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 122344: Define a Proper PointStyle Enum Across Kig
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-01-31 19:59:03
Message-ID: 20150131195903.13680.15472 () probe ! kde ! org
[Download RAW message or body]

--===============4908324051002207977==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122344/
-----------------------------------------------------------

Review request for KDE Edu.

Repository: kig

Description
-------

This avoids a number of magic constants across the code base.

Diffs
-----

  objects/object_drawer.cc f5adfb4 
  filters/cabri-filter.cc 16ee821 
  filters/cabri-utils.h c04ac44 
  filters/cabri-utils.cc d8ed666 
  filters/drgeo-filter.cc 586d863 
  filters/native-filter.cc 182b3c8 
  misc/kigpainter.h c67ff33 
  misc/kigpainter.cpp 9db6ec4 
  misc/special_constructors.cc 9929dfd 
  modes/popup/builtinobjectactionsprovider.cc ef1f81b 
  objects/object_drawer.h d3b634c 

Diff: https://git.reviewboard.kde.org/r/122344/diff/

Testing
-------

Started kig, drew things and changed point styles in those things.

Thanks,

David Narváez

--===============4908324051002207977==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122344/">https://git.reviewboard.kde.org/r/122344/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This avoids a number of magic constants across the \
code base.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Started kig, drew things and changed point styles in \
those things.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>objects/object_drawer.cc <span style="color: grey">(f5adfb4)</span></li>

 <li>filters/cabri-filter.cc <span style="color: grey">(16ee821)</span></li>

 <li>filters/cabri-utils.h <span style="color: grey">(c04ac44)</span></li>

 <li>filters/cabri-utils.cc <span style="color: grey">(d8ed666)</span></li>

 <li>filters/drgeo-filter.cc <span style="color: grey">(586d863)</span></li>

 <li>filters/native-filter.cc <span style="color: grey">(182b3c8)</span></li>

 <li>misc/kigpainter.h <span style="color: grey">(c67ff33)</span></li>

 <li>misc/kigpainter.cpp <span style="color: grey">(9db6ec4)</span></li>

 <li>misc/special_constructors.cc <span style="color: grey">(9929dfd)</span></li>

 <li>modes/popup/builtinobjectactionsprovider.cc <span style="color: \
grey">(ef1f81b)</span></li>

 <li>objects/object_drawer.h <span style="color: grey">(d3b634c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122344/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4908324051002207977==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 