'Re: Review Request 122248: Fixing the crash during autocompletion'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 122248: Fixing the crash during autocompletion
From:       "Filipe Saraiva" <filipe () kde ! org>
Date:       2015-01-30 19:05:01
Message-ID: 20150130190501.13680.66271 () probe ! kde ! org
[Download RAW message or body]

--===============4329155545313554177==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122248/#review75054
-----------------------------------------------------------

Hi Minh, unfortunately I am getting the same error when I follow your testing \
suggestion. Can not you to replicate this error?

- Filipe Saraiva

On Jan. 25, 2015, 4:59 p.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122248/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 4:59 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: 342888
> http://bugs.kde.org/show_bug.cgi?id=342888
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Fixes the crash during autocompletion.
> 
> This crash happened before possibly because you didn't select any item from the \
> completion list before pressing '.'. And then because of some logic it decided that \
> you don't need m_completionObject anymore and delete it. 
> Detailed stack trace is in the bug ticket.
> 
> I'm selecting the first item after pressing tab to avoid this problem. Looks like \
> all is working now like an user expects. 
> 
> Diffs
> -----
> 
> src/commandentry.cpp 7b7c657 
> 
> Diff: https://git.reviewboard.kde.org/r/122248/diff/
> 
> 
> Testing
> -------
> 
> 1. Select some backend (for example, Python 2);
> 2. Type "num" (without ") and press TAB;
> 3. Press "." (without ");
> 
> 
> Thanks,
> 
> Minh Ngo
> 
> 

--===============4329155545313554177==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122248/">https://git.reviewboard.kde.org/r/122248/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Minh, unfortunately I am getting the same error when I follow your testing \
suggestion. Can not you to replicate this error?</p></pre>  <br />

<p>- Filipe Saraiva</p>

<br />
<p>On Janeiro 25th, 2015, 4:59 p.m. UTC, Minh Ngo wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Minh Ngo.</div>

<p style="color: grey;"><i>Updated Jan. 25, 2015, 4:59 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=342888">342888</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixes the crash during autocompletion.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This crash happened before possibly because you didn't select any item from \
the completion list before pressing '.'. And then because of some logic it decided \
that you don't need m_completionObject anymore and delete it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Detailed stack trace is in the bug ticket.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
selecting the first item after pressing tab to avoid this problem. Looks like all is \
working now like an user expects.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Select some backend (for \
example, Python 2);</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Type "num" (without ") and press \
TAB;</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Press "." (without ");</li> </ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/commandentry.cpp <span style="color: grey">(7b7c657)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122248/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4329155545313554177==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 