[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 122186: Update deprecated code for accessing libkeduvocdocument.
From: "Rahul Chowdhury" <rahul.chowdhury () kdemail ! net>
Date: 2015-01-21 18:24:48
Message-ID: 20150121182448.32442.90764 () probe ! kde ! org
[Download RAW message or body]
--===============0138746330851606665==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122186/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 6:24 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Inge Wallin and Jeremy Whiting.
Repository: parley
Description
-------
Change the function calling statements in parley to update the code according to the \
new definitions in libkeduvocdocument.
Diffs
-----
src/collection/entryfilter.cpp 74614fe
src/editor/comparisonwidget.cpp d607bec
src/practice/comparisonbackendmode.cpp 1d27e84
src/scripts/scripting/translation.h 9ca3b82
Diff: https://git.reviewboard.kde.org/r/122186/diff/
Testing
-------
It builds with no errors/warnings.
Thanks,
Rahul Chowdhury
--===============0138746330851606665==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122186/">https://git.reviewboard.kde.org/r/122186/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Inge Wallin and Jeremy Whiting.</div>
<div>By Rahul Chowdhury.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2015, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change the function calling statements in parley to \
update the code according to the new definitions in libkeduvocdocument.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds with no errors/warnings.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/entryfilter.cpp <span style="color: grey">(74614fe)</span></li>
<li>src/editor/comparisonwidget.cpp <span style="color: grey">(d607bec)</span></li>
<li>src/practice/comparisonbackendmode.cpp <span style="color: \
grey">(1d27e84)</span></li>
<li>src/scripts/scripting/translation.h <span style="color: \
grey">(9ca3b82)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122186/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0138746330851606665==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic