'Re: Review Request 122166: KEduVocDocument: Mark document as dirty when grades are removed.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 122166: KEduVocDocument: Mark document as dirty when grades are removed.
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2015-01-20 17:33:16
Message-ID: 20150120173316.32442.29968 () probe ! kde ! org
[Download RAW message or body]

--===============4413147599344268312==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122166/
-----------------------------------------------------------

(Updated Jan. 20, 2015, 6:33 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Jeremy Whiting.

Repository: libkdeedu

Description
-------

This solves https://bugs.kde.org/show_bug.cgi?id=341139

Note that commenting out the test in the cmake file is not supposed to be in there. \
It's just that I had a link error and this was a quick and dirty way to solve that \
for the moment. It's not actually part of the patch.

Diffs
-----

  keduvocdocument/keduvoccontainer.cpp a7d7b3e 
  keduvocdocument/keduvocdocument.cpp 6ae7e43 
  keduvocdocument/keduvoclesson.h 967470f 
  keduvocdocument/keduvoclesson.cpp 2691ce4 
  keduvocdocument/CMakeLists.txt af0bdc2 
  keduvocdocument/keduvoccontainer.h 50a7165 

Diff: https://git.reviewboard.kde.org/r/122166/diff/

Testing
-------

Tested with an unpatched Parley. Works for both recursive and non-recursive versions \
of the action.

Thanks,

Inge Wallin

--===============4413147599344268312==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122166/">https://git.reviewboard.kde.org/r/122166/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Jeremy Whiting.</div>
<div>By Inge Wallin.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2015, 6:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdeedu
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This solves \
https://bugs.kde.org/show_bug.cgi?id=341139</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that commenting \
out the test in the cmake file is not supposed to be in there. It's just that I had a \
link error and this was a quick and dirty way to solve that for the moment. It's not \
actually part of the patch.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with an unpatched Parley. Works for both \
recursive and non-recursive versions of the action.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>keduvocdocument/keduvoccontainer.cpp <span style="color: \
grey">(a7d7b3e)</span></li>

 <li>keduvocdocument/keduvocdocument.cpp <span style="color: \
grey">(6ae7e43)</span></li>

 <li>keduvocdocument/keduvoclesson.h <span style="color: grey">(967470f)</span></li>

 <li>keduvocdocument/keduvoclesson.cpp <span style="color: \
grey">(2691ce4)</span></li>

 <li>keduvocdocument/CMakeLists.txt <span style="color: grey">(af0bdc2)</span></li>

 <li>keduvocdocument/keduvoccontainer.h <span style="color: \
grey">(50a7165)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122166/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4413147599344268312==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 