[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118860: Feature: Added entry selection prioritizers to practice.
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-01-13 22:21:22
Message-ID: 20150113222122.19347.63441 () probe ! kde ! org
[Download RAW message or body]
--===============3760543904276775376==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 21, 2014, 11:07 a.m., Andreas Xavier wrote:
> > ingwa,
> > This is not urgent.
> > Do you still want this feature?
>
> Inge Wallin wrote:
> I do, but I have to think a little about how it should be implemented.
>
> Albert Astals Cid wrote:
> ping
Ok, we are starting to work to get this included now.
- Inge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118860/#review62764
-----------------------------------------------------------
On June 21, 2014, 10:29 a.m., Andreas Xavier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118860/
> -----------------------------------------------------------
>
> (Updated June 21, 2014, 10:29 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: parley
>
>
> Description
> -------
>
> The patch adds new features as discussed with ingwa on IRC.
>
> This patch adds session entry prioritizers. The intent of the prioritizers are to \
> select which block of n entries will be practiced first, when the user doesn't have \
> time to practice all of the pending entries. There are three variants: default, \
> grab the first n entries; most invested, grab the n pending entries with the \
> highest grade thereby helping the user maintain their level; most urgent, grab the \
> n entries that are most overdue.
> Urgency is defined as the ratio of time since the entry stopped blocking over the \
> block time interval for its grade. This means urgency starts at 0 at time t when \
> the entry becomes available and increases linearly to 1 at time = t + blocking \
> time.
> The patch:
> 1. Added 2 options at Configure Practice -> General -> Sessions
> Session Mode: Fixed , Continuous
> Word Prioritization: Most Invested, Most Urgent
> note: SessionMode continuous is not activated because it was commented out in the \
> previous code. 2. Added unit tests for all three prioritizers.
> 3. Added default, investment and urgency based prioritizers that pass the unit \
> tests.
> note: I moved the preGrade blocking times out of a file-scope array of ints into \
> Prefs::
>
> Diffs
> -----
>
> CMakeLists.txt b741dc4
> autotests/CMakeLists.txt PRE-CREATION
> autotests/entryprioritizertest.cpp PRE-CREATION
> src/CMakeLists.txt a2da378
> src/configure-practice/configurepracticedialog.h ea1f7dd
> src/configure-practice/configurepracticedialog.cpp 0689dde
> src/configure-practice/generalpracticeoptions.ui 90a407f
> src/practice/entryfilter.h 7122ef6
> src/practice/entryfilter.cpp 614981f
> src/practice/entryprioritizerbase.h PRE-CREATION
> src/practice/entryprioritizerbase.cpp PRE-CREATION
> src/practice/entryprioritizerinvestment.h PRE-CREATION
> src/practice/entryprioritizerinvestment.cpp PRE-CREATION
> src/practice/entryprioritizerurgency.h PRE-CREATION
> src/practice/entryprioritizerurgency.cpp PRE-CREATION
> src/practice/sessionmanagerbase.h 257c450
> src/practice/sessionmanagerbase.cpp b45e591
> src/practice/sessionmanagerfixed.cpp 5000f62
> src/settings/parley.kcfg e0f48af
>
> Diff: https://git.reviewboard.kde.org/r/118860/diff/
>
>
> Testing
> -------
>
> Ran new unittest for prioritizers.
>
> Played multiple choice.
>
>
> Thanks,
>
> Andreas Xavier
>
>
--===============3760543904276775376==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118860/">https://git.reviewboard.kde.org/r/118860/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 21st, 2014, 11:07 a.m. UTC, <b>Andreas \
Xavier</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ingwa, This is not urgent.
Do you still want this feature?</p></pre>
</blockquote>
<p>On August 10th, 2014, 6:55 p.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do, \
but I have to think a little about how it should be implemented.</p></pre> \
</blockquote>
<p>On November 9th, 2014, 10:06 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
we are starting to work to get this included now.</p></pre> <br />
<p>- Inge</p>
<br />
<p>On June 21st, 2014, 10:29 a.m. UTC, Andreas Xavier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Andreas Xavier.</div>
<p style="color: grey;"><i>Updated June 21, 2014, 10:29 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch adds new features as discussed with ingwa on IRC.
This patch adds session entry prioritizers. The intent of the prioritizers are to \
select which block of n entries will be practiced first, when the user doesn't \
have time to practice all of the pending entries. There are three variants: default, \
grab the first n entries; most invested, grab the n pending entries with the highest \
grade thereby helping the user maintain their level; most urgent, grab the n entries \
that are most overdue.
Urgency is defined as the ratio of time since the entry stopped blocking over the \
block time interval for its grade. This means urgency starts at 0 at time t when the \
entry becomes available and increases linearly to 1 at time = t + blocking time.
The patch:
1. Added 2 options at Configure Practice -> General -> Sessions
Session Mode: Fixed , Continuous
Word Prioritization: Most Invested, Most Urgent
note: SessionMode continuous is not activated because it was commented out in the \
previous code. 2. Added unit tests for all three prioritizers.
3. Added default, investment and urgency based prioritizers that pass the unit tests.
note: I moved the preGrade blocking times out of a file-scope array of ints into \
Prefs::
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran new unittest for prioritizers.
Played multiple choice.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b741dc4)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/entryprioritizertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a2da378)</span></li>
<li>src/configure-practice/configurepracticedialog.h <span style="color: \
grey">(ea1f7dd)</span></li>
<li>src/configure-practice/configurepracticedialog.cpp <span style="color: \
grey">(0689dde)</span></li>
<li>src/configure-practice/generalpracticeoptions.ui <span style="color: \
grey">(90a407f)</span></li>
<li>src/practice/entryfilter.h <span style="color: grey">(7122ef6)</span></li>
<li>src/practice/entryfilter.cpp <span style="color: grey">(614981f)</span></li>
<li>src/practice/entryprioritizerbase.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/entryprioritizerbase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/entryprioritizerinvestment.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/entryprioritizerinvestment.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/entryprioritizerurgency.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/entryprioritizerurgency.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/sessionmanagerbase.h <span style="color: \
grey">(257c450)</span></li>
<li>src/practice/sessionmanagerbase.cpp <span style="color: \
grey">(b45e591)</span></li>
<li>src/practice/sessionmanagerfixed.cpp <span style="color: \
grey">(5000f62)</span></li>
<li>src/settings/parley.kcfg <span style="color: grey">(e0f48af)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118860/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3760543904276775376==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic