'Review Request 122038: Code after icon toggle'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 122038: Code after icon toggle
From:       "Souvik  Das" <souvikdas728 () gmail ! com>
Date:       2015-01-13 15:10:28
Message-ID: 20150113151028.19347.92476 () probe ! kde ! org
[Download RAW message or body]

--===============8784789323290552447==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122038/
-----------------------------------------------------------

Review request for KDE Edu.

Repository: kanagram

Description
-------

Changes to implement 2-player mode

Code keeping track of score for two player

Code before 2-player score implementation

Code before 2-player score implementation 2

KanagramGame shows score in UI(wrong score)

KanagramGame shows score in UI(wrong score) 2

Code after proper score implementation

Final Code after proper score implementation

SoK Project- Final Code- 2-player Feture added

Diffs
-----

  src/kanagram.kcfg 468e316528c413b8dc42d2e9d365b6fe63c63257 
  src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
  src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
  src/ui/Blackboard.qml e56b54f74471967ebc7b32ccaa96c72628ea7afd 
  src/ui/icons/1player.png PRE-CREATION 
  src/ui/icons/2player.png PRE-CREATION 
  src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 

Diff: https://git.reviewboard.kde.org/r/122038/diff/

Testing
-------

Thanks,

Souvik  Das

--===============8784789323290552447==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122038/">https://git.reviewboard.kde.org/r/122038/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Souvik  Das.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kanagram
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes to implement 2-player mode

Code keeping track of score for two player

Code before 2-player score implementation

Code before 2-player score implementation 2

KanagramGame shows score in UI(wrong score)

KanagramGame shows score in UI(wrong score) 2

Code after proper score implementation

Final Code after proper score implementation

SoK Project- Final Code- 2-player Feture added</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kanagram.kcfg <span style="color: \
grey">(468e316528c413b8dc42d2e9d365b6fe63c63257)</span></li>

 <li>src/kanagramgame.h <span style="color: \
grey">(e9564cfcc6a19a3ed5e63db5340cd19a760914d5)</span></li>

 <li>src/kanagramgame.cpp <span style="color: \
grey">(e0b60866ef49af3f28161c72982b17c6865f88ef)</span></li>

 <li>src/ui/Blackboard.qml <span style="color: \
grey">(e56b54f74471967ebc7b32ccaa96c72628ea7afd)</span></li>

 <li>src/ui/icons/1player.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ui/icons/2player.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ui/main.qml <span style="color: \
grey">(38408ae66772a578a45faeb92ff9828f7c174f2a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122038/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8784789323290552447==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 