[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 121983: Make it easier to spot the rotation of objects.
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-01-11 12:28:10
Message-ID: 20150111122810.19346.51825 () probe ! kde ! org
[Download RAW message or body]
--===============1121788703806419032==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121983/#review73733
-----------------------------------------------------------
Ship it!
Looks good. You can commit and push this patch. Good job!
PS. Don't forget the REVIEW: tag in the commit message
- Inge Wallin
On Jan. 11, 2015, 12:01 p.m., Rahul Chowdhury wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121983/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2015, 12:01 p.m.)
>
>
> Review request for KDE Edu and Inge Wallin.
>
>
> Repository: step
>
>
> Description
> -------
>
> A white line is drawn along the diameter of the given object so that it helps in \
> visualisation of the rotary motions.
>
> Diffs
> -----
>
> step/polygongraphics.h 763e830
> step/polygongraphics.cc 9242d88
> stepcore/collisionsolver.cc 9a263a8
>
> Diff: https://git.reviewboard.kde.org/r/121983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rahul Chowdhury
>
>
--===============1121788703806419032==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121983/">https://git.reviewboard.kde.org/r/121983/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good. You can commit and push this patch. Good job!</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS. \
Don't forget the REVIEW: tag in the commit message</p></pre> <br />
<p>- Inge Wallin</p>
<br />
<p>On January 11th, 2015, 12:01 p.m. UTC, Rahul Chowdhury wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Rahul Chowdhury.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2015, 12:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
step
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A white line is drawn along the diameter of the given \
object so that it helps in visualisation of the rotary motions.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>step/polygongraphics.h <span style="color: grey">(763e830)</span></li>
<li>step/polygongraphics.cc <span style="color: grey">(9242d88)</span></li>
<li>stepcore/collisionsolver.cc <span style="color: grey">(9a263a8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121983/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1121788703806419032==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic