'Re: Review Request 119141: make the stylesheet file shorter to avoid the 'memory-exhausted' error.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 119141: make the stylesheet file shorter to avoid the 'memory-exhausted' error.
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-01-08 2:59:34
Message-ID: 20150108025934.15695.44149 () probe ! kde ! org
[Download RAW message or body]

--===============2498113004468379035==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Nov. 9, 2014, 10:05 p.m., Albert Astals Cid wrote:
> > Ping review?
> 
> Albert Astals Cid wrote:
> Ping?

This patch has a longer story: this is to hack around a bug deep in Qt and I am \
waiting for me to fix the bug or give up and use this patch... haven't decided yet.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119141/#review70133
-----------------------------------------------------------

On July 6, 2014, 8 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119141/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 8 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> I added a QMap to the KigFilterGeogebra class which maps the Geogebra Object names \
> to the corresponding kig names. Then we can make the stylesheet file much shorter \
> and avoid the 'memory-exhausted' error. 
> I haven't filled the namesMap for all the objects. If you like this approach we can \
> move ahead with this. 
> 
> Diffs
> -----
> 
> filters/geogebra-filter.h 1b2b416 
> filters/geogebra-filter.cpp 53c9253 
> filters/geogebra.xsl a0809da 
> 
> Diff: https://git.reviewboard.kde.org/r/119141/diff/
> 
> 
> Testing
> -------
> 
> I tested it with an ellipse and a Conic-5-point objects. OK!!
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
> 

--===============2498113004468379035==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119141/">https://git.reviewboard.kde.org/r/119141/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On November 9th, 2014, 10:05 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ping review?</p></pre>  </blockquote>

 <p>On January 2nd, 2015, 9:31 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Ping?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch has a longer story: this is to hack around a bug deep in Qt and I am waiting \
for me to fix the bug or give up and use this patch... haven't decided yet.</p></pre> \
<br />

<p>- David</p>

<br />
<p>On July 6th, 2014, 8 a.m. UTC, Aniket Anvit wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>

<p style="color: grey;"><i>Updated July 6, 2014, 8 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I added a QMap to the KigFilterGeogebra class which \
maps the Geogebra Object names to the corresponding kig names. Then we can make the \
stylesheet file much shorter and avoid the 'memory-exhausted' error.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I haven't filled the namesMap for all the objects. If you like this \
approach we can move ahead with this.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I tested it with an ellipse and a Conic-5-point \
objects. OK!!</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/geogebra-filter.h <span style="color: grey">(1b2b416)</span></li>

 <li>filters/geogebra-filter.cpp <span style="color: grey">(53c9253)</span></li>

 <li>filters/geogebra.xsl <span style="color: grey">(a0809da)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119141/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2498113004468379035==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 