[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 121770: A bit of cleanup. Bump version to 3.0 since the
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2014-12-31 1:18:45
Message-ID: 20141231011845.18352.12971 () probe ! kde ! org
[Download RAW message or body]
--===============4603762887660177284==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121770/
-----------------------------------------------------------
(Updated Dec. 31, 2014, 1:18 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu and Rahul Chowdhury.
Repository: khangman
Description
-------
A bit of cleanup. Bump version to 3.0 since the whole ui is different. Remove unused private \
data from khangman class. Cleanup includes a bit. Remove commented out lines of code. Add \
.reviewboardrc file. renamed sound property to soundEnabled and tweaked methods for \
consistency.
Diffs
-----
.reviewboardrc PRE-CREATION
src/khangman.h defb2c30fe0926c96a86f704098b90846a3809bb
src/khangman.cpp af394b994479f40e68cc8b2304487201cf349b19
src/main.cpp 7ea4e32abb86bf924f26fc592fcc3622acfd6c83
src/qml/CMakeLists.txt 47d84c2caab8218395a58849489035687344f949
src/qml/GamePage.qml 3f573ca5d6d4ffd62c4888703496fd21e7ea63b3
src/qml/MainSettingsDialog.qml 4a41f76d44e74681b109a099d2d0a07a9094ecbe
src/qml/UIConstants.js 263a196cf00bb7526bc1d9c7b43ab03c5e313bb3
src/qml/main.qml 215d2fbee7cbb7ce90cf238629960e46b9963f21
src/qml/sounds/CMakeLists.txt c3ec706a97ff32057cb7c03ef86a86cb8b96a96f
src/version.h 617549f4add19c136b75dba754d136f1d15a2c86
Diff: https://git.reviewboard.kde.org/r/121770/diff/
Testing
-------
It builds and runs still.
Thanks,
Jeremy Whiting
--===============4603762887660177284==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121770/">https://git.reviewboard.kde.org/r/121770/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Rahul Chowdhury.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2014, 1:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khangman
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A bit of \
cleanup. Bump version to 3.0 since the whole ui is different. Remove unused private data from \
khangman class. Cleanup includes a bit. Remove commented out lines of code. Add .reviewboardrc \
file. renamed sound property to soundEnabled and tweaked methods for consistency.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds and \
runs still.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/khangman.h <span style="color: \
grey">(defb2c30fe0926c96a86f704098b90846a3809bb)</span></li>
<li>src/khangman.cpp <span style="color: \
grey">(af394b994479f40e68cc8b2304487201cf349b19)</span></li>
<li>src/main.cpp <span style="color: \
grey">(7ea4e32abb86bf924f26fc592fcc3622acfd6c83)</span></li>
<li>src/qml/CMakeLists.txt <span style="color: \
grey">(47d84c2caab8218395a58849489035687344f949)</span></li>
<li>src/qml/GamePage.qml <span style="color: \
grey">(3f573ca5d6d4ffd62c4888703496fd21e7ea63b3)</span></li>
<li>src/qml/MainSettingsDialog.qml <span style="color: \
grey">(4a41f76d44e74681b109a099d2d0a07a9094ecbe)</span></li>
<li>src/qml/UIConstants.js <span style="color: \
grey">(263a196cf00bb7526bc1d9c7b43ab03c5e313bb3)</span></li>
<li>src/qml/main.qml <span style="color: \
grey">(215d2fbee7cbb7ce90cf238629960e46b9963f21)</span></li>
<li>src/qml/sounds/CMakeLists.txt <span style="color: \
grey">(c3ec706a97ff32057cb7c03ef86a86cb8b96a96f)</span></li>
<li>src/version.h <span style="color: \
grey">(617549f4add19c136b75dba754d136f1d15a2c86)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121770/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4603762887660177284==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic