[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 121750: Remove phonon dependency. Use QtMultimedia in qml
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2014-12-30 16:06:11
Message-ID: 20141230160611.18352.14914 () probe ! kde ! org
[Download RAW message or body]
--===============5729069117143687873==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 30, 2014, 1:08 a.m., Andreas Cord-Landwehr wrote:
> > Sounds like a good idea to have less dependencies, especially for deployment on \
> > non-desktop devices. My only concern is that the GStreamer-1.x port of \
> > QtMultimedia is only merged into the dev-branch of QtMultimedia. And from my \
> > experience GStreamer0.10 can make/makes sometimes a lot of problems (since \
> > unmaintained since years and hence not well tested against e.g. recent pulseaudio \
> > releases).
> > That said, probably it is good to do the change now, since there is now a long \
> > time for testing how well it works.
> > Directly to your patch: there now seem to be some empty if/else clauses and also \
> > an empty function (e.g. KanagramGame::wordRevealed()). Shouldn't there be at \
> > least a comment why there is no code? Or otherwise, if not needed, shouldn't it \
> > be removed directly?
Yep, I'll fix that and update this review today.
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121750/#review72771
-----------------------------------------------------------
On Dec. 29, 2014, 11:28 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121750/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2014, 11:28 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: kanagram
>
>
> Description
> -------
>
> Remove phonon dependency. Use QtMultimedia in qml instead for sounds. Move sound \
> files to src/ui/sounds and install them with the other qml files.
>
> Diffs
> -----
>
> CMakeLists.txt 5b847b98eb17cf8f846f3327324c6dae54e1ef12
> sounds/CMakeLists.txt eb03a902fedde15fb9ebac8d623c77001f42559b
> sounds/anagram-letter-press.wav 27abcd9d8d0bf644e9e78531b2b56f0b348eded3
> sounds/chalk.ogg
> sounds/chalk.wav
> sounds/right.ogg
> sounds/right.wav
> sounds/wrong.ogg
> sounds/wrong.wav
> src/CMakeLists.txt b8628fdf7d82068b4c4d59479662a3fc36cef3fc
> src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5
> src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef
> src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a
>
> Diff: https://git.reviewboard.kde.org/r/121750/diff/
>
>
> Testing
> -------
>
> Sounds still work as expected when Use Sounds is checked in preferences. Required \
> some gst plugins locally, but that's an acceptable runtime requirement imo.
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============5729069117143687873==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121750/">https://git.reviewboard.kde.org/r/121750/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2014, 1:08 a.m. MST, <b>Andreas \
Cord-Landwehr</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sounds like a good idea to have less dependencies, \
especially for deployment on non-desktop devices. My only concern is that the \
GStreamer-1.x port of QtMultimedia is only merged into the dev-branch of \
QtMultimedia. And from my experience GStreamer0.10 can make/makes sometimes a lot of \
problems (since unmaintained since years and hence not well tested against e.g. \
recent pulseaudio releases).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">That said, probably it is good to do \
the change now, since there is now a long time for testing how well it works.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Directly to your patch: there now seem to be some empty if/else clauses and \
also an empty function (e.g. KanagramGame::wordRevealed()). Shouldn't there be at \
least a comment why there is no code? Or otherwise, if not needed, shouldn't it be \
removed directly?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yep, \
I'll fix that and update this review today.</p></pre> <br />
<p>- Jeremy</p>
<br />
<p>On December 29th, 2014, 11:28 p.m. MST, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2014, 11:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kanagram
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove phonon dependency. Use QtMultimedia in qml \
instead for sounds. Move sound files to src/ui/sounds and install them with the other \
qml files.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sounds still work as expected when Use Sounds is \
checked in preferences. Required some gst plugins locally, but that's an acceptable \
runtime requirement imo.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(5b847b98eb17cf8f846f3327324c6dae54e1ef12)</span></li>
<li>sounds/CMakeLists.txt <span style="color: \
grey">(eb03a902fedde15fb9ebac8d623c77001f42559b)</span></li>
<li>sounds/anagram-letter-press.wav <span style="color: \
grey">(27abcd9d8d0bf644e9e78531b2b56f0b348eded3)</span></li>
<li>sounds/chalk.ogg <span style="color: grey">()</span></li>
<li>sounds/chalk.wav <span style="color: grey">()</span></li>
<li>sounds/right.ogg <span style="color: grey">()</span></li>
<li>sounds/right.wav <span style="color: grey">()</span></li>
<li>sounds/wrong.ogg <span style="color: grey">()</span></li>
<li>sounds/wrong.wav <span style="color: grey">()</span></li>
<li>src/CMakeLists.txt <span style="color: \
grey">(b8628fdf7d82068b4c4d59479662a3fc36cef3fc)</span></li>
<li>src/kanagramgame.h <span style="color: \
grey">(e9564cfcc6a19a3ed5e63db5340cd19a760914d5)</span></li>
<li>src/kanagramgame.cpp <span style="color: \
grey">(e0b60866ef49af3f28161c72982b17c6865f88ef)</span></li>
<li>src/ui/main.qml <span style="color: \
grey">(38408ae66772a578a45faeb92ff9828f7c174f2a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121750/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5729069117143687873==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic