'Re: Review Request 121745: 2player implememtation Code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 121745: 2player implememtation Code
From:       "Souvik  Das" <souvikdas728 () gmail ! com>
Date:       2014-12-29 21:06:48
Message-ID: 20141229210648.18351.79809 () probe ! kde ! org
[Download RAW message or body]

--===============6698121144589325706==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121745/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 9:06 p.m.)

Review request for KDE Edu and Jeremy Whiting.

Repository: kanagram

Description
-------

The texts 1st player and 2nd players, works only when app is restarted, and not \
triggered on mode change. Also it does not change to 2nd player after the timer is \
up. And nor does the timer starts for 2nd player.

Diffs (updated)
-----

  src/kanagram.kcfg 468e316528c413b8dc42d2e9d365b6fe63c63257 
  src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
  src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
  src/ui/icons/1player.png PRE-CREATION 
  src/ui/icons/2player.png PRE-CREATION 
  src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 

Diff: https://git.reviewboard.kde.org/r/121745/diff/

Testing
-------

Thanks,

Souvik  Das

--===============6698121144589325706==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121745/">https://git.reviewboard.kde.org/r/121745/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Jeremy Whiting.</div>
<div>By Souvik  Das.</div>

<p style="color: grey;"><i>Updated Dec. 29, 2014, 9:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kanagram
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The texts 1st player and 2nd players, works only when \
app is restarted, and not triggered on mode change. Also it does not change to 2nd \
player after the timer is up. And nor does the timer starts for 2nd player.</p></pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kanagram.kcfg <span style="color: \
grey">(468e316528c413b8dc42d2e9d365b6fe63c63257)</span></li>

 <li>src/kanagramgame.h <span style="color: \
grey">(e9564cfcc6a19a3ed5e63db5340cd19a760914d5)</span></li>

 <li>src/kanagramgame.cpp <span style="color: \
grey">(e0b60866ef49af3f28161c72982b17c6865f88ef)</span></li>

 <li>src/ui/icons/1player.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ui/icons/2player.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ui/main.qml <span style="color: \
grey">(38408ae66772a578a45faeb92ff9828f7c174f2a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121745/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6698121144589325706==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 