[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 121374: Cantor Python2 to Python3 backend porting for KF5
From:       "Minh Ngo" <nlminhtl () gmail ! com>
Date:       2014-12-28 17:32:51
Message-ID: 20141228173251.18351.58983 () probe ! kde ! org
[Download RAW message or body]

--===============5499518283949292483==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121374/
-----------------------------------------------------------

(Updated Dec. 28, 2014, 5:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Repository: cantor


Description
-------

Have meda some fixes in cmake files to find python3 correctly...


Diffs
-----

  src/backends/python2/python2backend.cpp PRE-CREATION 
  src/backends/python3/CMakeLists.txt PRE-CREATION 
  src/backends/python3/cantor_python3.knsrc PRE-CREATION 
  src/backends/python3/python3backend.h PRE-CREATION 
  src/backends/python3/python3backend.cpp PRE-CREATION 
  src/backends/python3/python3backend.desktop PRE-CREATION 
  cmake/FindPythonLibs3.cmake PRE-CREATION 
  src/backends/CMakeLists.txt e27c84d 
  src/backends/R/cantor_r.knsrc 02f9a1e 
  src/backends/kalgebra/cantor_kalgebra.knsrc d0103eb 
  src/backends/lua/cantor_lua.knsrc 25165d0 
  src/backends/maxima/cantor_maxima.knsrc 7cccce8 
  src/backends/octave/cantor_octave.knsrc 735739a 
  src/backends/python/pythonbackend.h 553eef0 
  src/backends/python/pythonbackend.cpp 3f66f39 
  src/backends/python/pythoncompletionobject.h 1c220a5 
  src/backends/python/pythonexpression.h aa34258 
  src/backends/python/pythonexpression.cpp 883c3ea 
  src/backends/python/pythonsession.h 3e716bc 
  src/backends/python/pythonsession.cpp c252572 
  src/backends/python2/CMakeLists.txt 260c2f0 
  src/backends/python2/cantor_python2.knsrc 7ec699c 
  src/backends/python2/python2backend.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121374/diff/


Testing
-------

1)
a = 1
b = 2
print(a + b)

2)
import numpy as np
a = np.array([1, 2, 3])
print(a)


Thanks,

Minh Ngo


--===============5499518283949292483==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121374/">https://git.reviewboard.kde.org/r/121374/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Minh Ngo.</div>


<p style="color: grey;"><i>Updated Dec. 28, 2014, 5:32 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Have meda some fixes in cmake files to find python3 \
correctly...</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">1) a = 1
b = 2
print(a + b)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">2) import numpy as np
a = np.array([1, 2, 3])
print(a)</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/python2/python2backend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/python3/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/python3/cantor_python3.knsrc <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/python3/python3backend.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/python3/python3backend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/python3/python3backend.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>cmake/FindPythonLibs3.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/CMakeLists.txt <span style="color: grey">(e27c84d)</span></li>

 <li>src/backends/R/cantor_r.knsrc <span style="color: grey">(02f9a1e)</span></li>

 <li>src/backends/kalgebra/cantor_kalgebra.knsrc <span style="color: \
grey">(d0103eb)</span></li>

 <li>src/backends/lua/cantor_lua.knsrc <span style="color: \
grey">(25165d0)</span></li>

 <li>src/backends/maxima/cantor_maxima.knsrc <span style="color: \
grey">(7cccce8)</span></li>

 <li>src/backends/octave/cantor_octave.knsrc <span style="color: \
grey">(735739a)</span></li>

 <li>src/backends/python/pythonbackend.h <span style="color: \
grey">(553eef0)</span></li>

 <li>src/backends/python/pythonbackend.cpp <span style="color: \
grey">(3f66f39)</span></li>

 <li>src/backends/python/pythoncompletionobject.h <span style="color: \
grey">(1c220a5)</span></li>

 <li>src/backends/python/pythonexpression.h <span style="color: \
grey">(aa34258)</span></li>

 <li>src/backends/python/pythonexpression.cpp <span style="color: \
grey">(883c3ea)</span></li>

 <li>src/backends/python/pythonsession.h <span style="color: \
grey">(3e716bc)</span></li>

 <li>src/backends/python/pythonsession.cpp <span style="color: \
grey">(c252572)</span></li>

 <li>src/backends/python2/CMakeLists.txt <span style="color: \
grey">(260c2f0)</span></li>

 <li>src/backends/python2/cantor_python2.knsrc <span style="color: \
grey">(7ec699c)</span></li>

 <li>src/backends/python2/python2backend.h <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121374/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============5499518283949292483==--



_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic