[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 121663: Refactor unit tests to make them stand-alone.
From:       "Andreas Cord-Landwehr" <cordlandwehr () kde ! org>
Date:       2014-12-27 13:27:32
Message-ID: 20141227132732.13119.71738 () probe ! kde ! org
[Download RAW message or body]

--===============5671739762097828396==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121663/
-----------------------------------------------------------

(Updated Dec. 27, 2014, 1:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Repository: step


Description
-------

Create stand-alone unit tests for unrelated tests that were
previously grouped as a single unit test. Also change unit test
names to default names as used for KF5.


Diffs
-----

  CMakeLists.txt 6d1630087050dc8b663752381d5c072f7caf95c2 
  autotests/CMakeLists.txt PRE-CREATION 
  autotests/test_contacts.h PRE-CREATION 
  autotests/test_metaobject.h PRE-CREATION 
  autotests/test_worldcopy.h PRE-CREATION 
  stepcore_tests/CMakeLists.txt ea52ffd3ec09988ec746d5d0599737b1b174ab1c 
  stepcore_tests/contacts.cc fa0d85da3d8a497eec4a1afd69280946e6394d41 
  stepcore_tests/maintest.h f8aa97cfb195ab7f6000b80e7ad57d9b6f1a3d3d 
  stepcore_tests/maintest.cc 9f7963b757725904793e5322a8046e7f10d67e45 
  stepcore_tests/metaobject.cc 2dd618c9d3ff8973ca63929ee3492668bca7fae2 
  stepcore_tests/worldcopy.cc c015ae29939bb647a0c9fa497e413d8c4ec29692 

Diff: https://git.reviewboard.kde.org/r/121663/diff/


Testing
-------

All enabled tests pass successfully, the additional one was already commented out and \
has to be fixed in a later commit.


Thanks,

Andreas Cord-Landwehr


--===============5671739762097828396==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121663/">https://git.reviewboard.kde.org/r/121663/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Andreas Cord-Landwehr.</div>


<p style="color: grey;"><i>Updated Dec. 27, 2014, 1:27 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
step
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Create stand-alone unit tests for unrelated tests that \
were previously grouped as a single unit test. Also change unit test
names to default names as used for KF5.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All enabled tests pass successfully, the additional \
one was already commented out and has to be fixed in a later commit.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(6d1630087050dc8b663752381d5c072f7caf95c2)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/test_contacts.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/test_metaobject.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/test_worldcopy.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>stepcore_tests/CMakeLists.txt <span style="color: \
grey">(ea52ffd3ec09988ec746d5d0599737b1b174ab1c)</span></li>

 <li>stepcore_tests/contacts.cc <span style="color: \
grey">(fa0d85da3d8a497eec4a1afd69280946e6394d41)</span></li>

 <li>stepcore_tests/maintest.h <span style="color: \
grey">(f8aa97cfb195ab7f6000b80e7ad57d9b6f1a3d3d)</span></li>

 <li>stepcore_tests/maintest.cc <span style="color: \
grey">(9f7963b757725904793e5322a8046e7f10d67e45)</span></li>

 <li>stepcore_tests/metaobject.cc <span style="color: \
grey">(2dd618c9d3ff8973ca63929ee3492668bca7fae2)</span></li>

 <li>stepcore_tests/worldcopy.cc <span style="color: \
grey">(c015ae29939bb647a0c9fa497e413d8c4ec29692)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121663/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============5671739762097828396==--



_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic