'Re: Review Request 121184: Adjust dashboard to have QScrollArea around collection widgets.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 121184: Adjust dashboard to have QScrollArea around collection widgets.
From:       Marko_Käning <mk-lists () email ! de>
Date:       2014-11-20 22:55:32
Message-ID: 20141120225532.22978.55623 () probe ! kde ! org
[Download RAW message or body]

--===============8168392686265951555==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Nov. 20, 2014, 11:47 p.m., Inge Wallin wrote:
> > Scrolling works fine now.  There are some rendering glitches but that is not due \
> > to this patch.

Yes, these - see https://bugs.kde.org/show_bug.cgi?id=341138 - need to be addressed \
by a new RR.

- Marko

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121184/#review70719
-----------------------------------------------------------

On Nov. 20, 2014, 11:49 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121184/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 11:49 p.m.)
> 
> 
> Review request for KDE Edu, Andreas Xavier, Inge Wallin, and Marko Käning.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> (cherry picked from commit 77e86e4a6cb806a9ad952c1a6ff3966be988c0f2)
> 
> Conflicts:
> 	src/dashboard/collectionwidget.cpp
> 	src/dashboard/dashboard.cpp
> 	src/dashboard/dashboard.ui
> 
> 
> Diffs
> -----
> 
> src/dashboard/collectionwidget.cpp 6898d1902bfdd64f615dd7350dcc9c477225908e 
> src/dashboard/dashboard.h b72722c02f730b7ea27065b17ca531bd96c32f43 
> src/dashboard/dashboard.cpp 11eb5bbc2d379d0d770b53181adf5416504732b9 
> src/dashboard/dashboard.ui 70c7eb180b6465d520f0547aa12925c64aa5c71f 
> 
> Diff: https://git.reviewboard.kde.org/r/121184/diff/
> 
> 
> Testing
> -------
> 
> It builds and runs and the scrollarea scrollbars appear when the view gets too \
> small as expected. 
> I have similar commits for Applications/14.12 and master here that we can review \
> separately or just push that do the same thing. 
> 
> Thanks,
> 
> Jeremy Whiting
> 
> 

--===============8168392686265951555==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121184/">https://git.reviewboard.kde.org/r/121184/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On November 20th, 2014, 11:47 p.m. CET, <b>Inge \
Wallin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Scrolling works fine now.  There are some rendering \
glitches but that is not due to this patch.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
these - see https://bugs.kde.org/show_bug.cgi?id=341138 - need to be addressed by a \
new RR.</p></pre> <br />

<p>- Marko</p>

<br />
<p>On November 20th, 2014, 11:49 p.m. CET, Jeremy Whiting wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Andreas Xavier, Inge Wallin, and Marko \
Käning.</div> <div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated Nov. 20, 2014, 11:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(cherry picked from commit \
77e86e4a6cb806a9ad952c1a6ff3966be988c0f2)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Conflicts: &amp;nbsp;  \
src/dashboard/collectionwidget.cpp &amp;nbsp;  src/dashboard/dashboard.cpp
&amp;nbsp;  src/dashboard/dashboard.ui</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds and runs and the scrollarea scrollbars \
appear when the view gets too small as expected.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
have similar commits for Applications/14.12 and master here that we can review \
separately or just push that do the same thing.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dashboard/collectionwidget.cpp <span style="color: \
grey">(6898d1902bfdd64f615dd7350dcc9c477225908e)</span></li>

 <li>src/dashboard/dashboard.h <span style="color: \
grey">(b72722c02f730b7ea27065b17ca531bd96c32f43)</span></li>

 <li>src/dashboard/dashboard.cpp <span style="color: \
grey">(11eb5bbc2d379d0d770b53181adf5416504732b9)</span></li>

 <li>src/dashboard/dashboard.ui <span style="color: \
grey">(70c7eb180b6465d520f0547aa12925c64aa5c71f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121184/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8168392686265951555==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 