'Re: Review Request 121170: Use QLocale to get language names.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 121170: Use QLocale to get language names.
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2014-11-18 20:28:45
Message-ID: 20141118202845.22978.95184 () probe ! kde ! org
[Download RAW message or body]

--===============3098358177563974174==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121170/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 8:28 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Laurent Navet.

Repository: klettres

Description
-------

all_languages has become kf5_all_languages, but QLocale gives us
native language names, so just use it like we do in KHangMan, KAnagram, etc.

Diffs
-----

  src/langutils.cpp 2343cd9f49f8028d48942dbd58e751a2e50f79f5 

Diff: https://git.reviewboard.kde.org/r/121170/diff/

Testing
-------

Without this patch the Language menu says "None" for every language we have data for. \
With it the language names are shown in their native language.

Thanks,

Jeremy Whiting

--===============3098358177563974174==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121170/">https://git.reviewboard.kde.org/r/121170/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Laurent Navet.</div>
<div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated Nov. 18, 2014, 8:28 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
klettres
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">all_languages has become kf5_all_languages, but \
QLocale gives us native language names, so just use it like we do in KHangMan, \
KAnagram, etc.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Without this patch the Language menu says "None" for \
every language we have data for. With it the language names are shown in their native \
language.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/langutils.cpp <span style="color: \
grey">(2343cd9f49f8028d48942dbd58e751a2e50f79f5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121170/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3098358177563974174==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 