'Re: Review Request 120923: Remove unused dependencies.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 120923: Remove unused dependencies.
From:       "Michael Palimaka" <kensington () gentoo ! org>
Date:       2014-10-31 19:07:24
Message-ID: 20141031190724.4240.2922 () probe ! kde ! org
[Download RAW message or body]

--===============0444295513634892438==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120923/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 7:07 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Repository: libkeduvocdocument

Description
-------

Tests use QCoreApplication from QtCore instead of QApplication from \
QtWidgets allowing that dependency to be dropped. QFont header is not used \
at all. KF5Config does not appear to be used at all.

Diffs
-----

  CMakeLists.txt a37ddc59bd56e47a96cd211da57c2e99c8eba9c0 
  keduvocdocument/CMakeLists.txt a207f3edce9ff726209c3a21a0c069d3f296ad38 
  keduvocdocument/readerwriters/keduvocwqlreader.cpp \
539246efa84b4dcc74121a78c20c0dfa2187b097   \
keduvocdocument/tests/CMakeLists.txt \
87182511d4e8fa4c03fc0a7d3644cc57dde19469   \
keduvocdocument/tests/converter.cpp \
b97d55ad5f764748a9f7f0487f94d9db1ac99371   \
keduvocdocument/tests/sharedkvtmlfilestest.cpp \
4893485473357ff8be279c8850674f9dea8fef89 

Diff: https://git.reviewboard.kde.org/r/120923/diff/

Testing
-------

Inspected source, builds, tests pass.

Thanks,

Michael Palimaka

--===============0444295513634892438==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120923/">https://git.reviewboard.kde.org/r/120923/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2014, 7:07 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Tests use QCoreApplication \
from QtCore instead of QApplication from QtWidgets allowing that dependency \
to be dropped. QFont header is not used at all. KF5Config does not appear \
to be used at all.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Inspected source, builds, \
tests pass.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(a37ddc59bd56e47a96cd211da57c2e99c8eba9c0)</span></li>

 <li>keduvocdocument/CMakeLists.txt <span style="color: \
grey">(a207f3edce9ff726209c3a21a0c069d3f296ad38)</span></li>

 <li>keduvocdocument/readerwriters/keduvocwqlreader.cpp <span style="color: \
grey">(539246efa84b4dcc74121a78c20c0dfa2187b097)</span></li>

 <li>keduvocdocument/tests/CMakeLists.txt <span style="color: \
grey">(87182511d4e8fa4c03fc0a7d3644cc57dde19469)</span></li>

 <li>keduvocdocument/tests/converter.cpp <span style="color: \
grey">(b97d55ad5f764748a9f7f0487f94d9db1ac99371)</span></li>

 <li>keduvocdocument/tests/sharedkvtmlfilestest.cpp <span style="color: \
grey">(4893485473357ff8be279c8850674f9dea8fef89)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120923/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0444295513634892438==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 