'Re: Review Request 120895: Use new format for generating filter string for QDialog use.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 120895: Use new format for generating filter string for QDialog use.
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2014-10-29 19:54:27
Message-ID: 20141029195427.23656.38073 () probe ! kde ! org
[Download RAW message or body]

--===============5704108303568585048==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120895/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 7:54 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Andreas Xavier and Inge Wallin.

Repository: libkeduvocdocument

Description
-------

QFileDialog filter strings have name (*.ext) and are separated by ;; \
instead of newlines.

Diffs
-----

  keduvocdocument/keduvocdocument.cpp \
b73025b6e5835f661c7dadeb6f93cd80f4279336 

Diff: https://git.reviewboard.kde.org/r/120895/diff/

Testing
-------

Parley open file now shows all the filters, not just csv.

Thanks,

Jeremy Whiting

--===============5704108303568585048==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120895/">https://git.reviewboard.kde.org/r/120895/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Andreas Xavier and Inge Wallin.</div>
<div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated Oct. 29, 2014, 7:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">QFileDialog filter strings \
have name (*.ext) and are separated by ;; instead of newlines.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Parley open file now shows \
all the filters, not just csv.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>keduvocdocument/keduvocdocument.cpp <span style="color: \
grey">(b73025b6e5835f661c7dadeb6f93cd80f4279336)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120895/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5704108303568585048==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 