[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 120254: [Kalzium] Minor fixes, reorganize includes, some cleanups
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-09-28 16:13:53
Message-ID: 20140928161353.15675.99316 () probe ! kde ! org
[Download RAW message or body]
--===============4663709477773373333==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120254/#review67567
-----------------------------------------------------------
I honestly still don't see the point of this commit, you're reordering some includes \
most of the times just for "perfection" of sorting, well, i'm sorry to tell you the \
next guy that comes and patches is going to break it, for those things you either \
have commit hooks or will break, you also remove some local includes like cctype in \
one file, well the C++ includes are different in lots of systems, do you know that it \
will not break for example std::isdigit in there?
For most of your changes i see no real gain and i can forsee some pain.
- Albert Astals Cid
On set. 20, 2014, 1:39 a.m., Martin Walch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120254/
> -----------------------------------------------------------
>
> (Updated set. 20, 2014, 1:39 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: kalzium
>
>
> Description
> -------
>
> * src/calculator/titrationCalculator.cpp:
>
> replace
> > if (!texto) {
> > QMessageBox::critical(this, "Error", "Unable to open " + file);
> > }
> > if (texto) {
>
> with
> > if (!texto) {
> > QMessageBox::critical(this, "Error", "Unable to open " + file);
> > } else {
>
> to emphasize that they are logically alternative
>
> * src/calculator/titrationCalculator.cpp:
> Fix "warning: 'cn' may be used uninitialized in this function".
> As far as I see, this has no proper initialization at all and should
> horribly fail. However, in all my tests it behaved as if it was properly
> initialized with 0.0. Maybe there is some compiler (gcc) magic at work.
> Nevermind. Just fix it.
>
> * libscience/spectrum.cpp:
> this line goes wrong
> > double newInt = p->intensity * 1000 / maxInt;
> because all three of p->intensity, 1000, and maxInt are Integers. Fix it
> with floating point number 1000.0. (The method is not used anywhere in
> Kalzium, but it is part of the libscience library)
>
> * further cleanup of includes:
>
> replace
> > #include <qclass.h>
>
> with
> > #include <QtModule/QClass>
>
> replace
> > #include <QtModule/QClass>
>
> with
> > #include <QClass>
>
> replace
> > #include <kclass.h>
>
> with
> > #include <KClass>
>
> replace
> > #include <QtModule>
>
> with the classes of QtModule that are actually necessary.
>
> use forward declarations and move includes into cpp files
>
> remove duplicate or unused includes
>
> (As a side note: single threaded build time reduced by roughly 5%)
>
> * Drop C bindings in favor of explicit C++ bindings
> (e.g. include cctype, not ctype.h and use std namespace)
>
> * Replace abs() and isfinite() with their corresponding Qt equivalents
> qAbs() and qIsFinite().
>
> * Replace M_PI with const double PI = 3.141... as M_PI is bad for
> portability.
>
>
> Diffs
> -----
>
> compoundviewer/kalziumglpart.h 0881df1
> compoundviewer/kalziumglpart.cpp 001399d
> compoundviewer/openbabel2wrapper.cpp 85406e1
> libscience/chemicaldataobject.h 55a40dc
> libscience/chemicaldataobject.cpp 8fac92c
> libscience/element.h 43979d9
> libscience/element.cpp 762462f
> libscience/elementparser.h f3a8130
> libscience/elementparser.cpp 7c5ecaf
> libscience/isotope.cpp 91db538
> src/psetable/elementitem.cpp a2b238c
> src/psetable/numerationitem.h 5cf8afb
> src/psetable/numerationitem.cpp 574f74f
> src/psetable/periodictablescene.h c89044b
> src/psetable/periodictablescene.cpp 5ea99c0
> src/psetable/periodictablestates.h f8258c3
> src/psetable/periodictablestates.cpp 501b75e
> src/psetable/periodictableview.h 366480e
> src/psetable/periodictableview.cpp 9669e5b
> src/psetable/statemachine.h 0cad142
> src/psetable/statemachine.cpp 9ce8d58
> src/rsdialog.h 930276c
> src/rsdialog.cpp 64a6b60
> src/search.h 83bcf66
> src/search.cpp 7ff6464
> src/isotopetable/isotopeitem.h 5b7840b
> src/isotopetable/isotopeitem.cpp b98155d
> src/isotopetable/isotopescene.cpp 18f6a54
> src/isotopetable/isotopetabledialog.h 4f075c5
> src/isotopetable/isotopetabledialog.cpp 83fb000
> src/isotopetable/isotopeview.h 54d3d97
> src/isotopetable/isotopeview.cpp dd6bc8e
> src/kalzium.h 86e4a6d
> src/kalzium.cpp 2e85cf8
> src/kalziumdataobject.h 0d88856
> src/kalziumdataobject.cpp e962670
> src/kalziumelementproperty.h f8b3a67
> src/kalziumelementproperty.cpp c42ecd5
> src/kalziumgradienttype.cpp 5130f85
> src/kalziumnumerationtype.cpp 52275d0
> src/kalziumschemetype.h a6447d5
> src/kalziumschemetype.cpp d35a97c
> src/kalziumutils.h 0938b34
> src/kalziumutils.cpp bae9c54
> src/kdeeduglossary.h 3b47aee
> src/kdeeduglossary.cpp f561568
> src/legendwidget.h 9794f07
> src/legendwidget.cpp b0a7ba0
> src/main.cpp ff492f0
> src/molcalcwidget.h a0581a0
> src/molcalcwidget.cpp 784928a
> src/orbitswidget.cpp d94ccf1
> src/psetable/elementitem.h 7dd7e30
> src/searchwidget.cpp 17edc1b
> src/spectrumviewimpl.h 881609f
> src/spectrumviewimpl.cpp f9c0488
> src/spectrumwidget.h 4caecb4
> src/spectrumwidget.cpp 2264590
> src/tableinfowidget.h dcfeea7
> src/tableinfowidget.cpp 48eb865
> src/tablesdialog.h a04f4ad
> src/tablesdialog.cpp 6dd126e
> src/tools/moleculeview.h 73bf9b8
> src/tools/moleculeview.cpp 7a6c9f3
> src/tools/obconverter.cpp 04b557d
> src/unitsettingsdialog.h 04d5cf0
> src/unitsettingsdialog.cpp 4f50aca
> src/detailedgraphicaloverview.cpp 5fb716b
> src/detailinfodlg.h e81802b
> src/detailinfodlg.cpp 5932a7f
> src/elementdataviewer.h dba156e
> src/elementdataviewer.cpp 49a2a18
> src/eqchemview.h 59d3384
> src/eqchemview.cpp ebce0be
> src/exportdialog.h 7aa5543
> src/exportdialog.cpp a21dc26
> src/gradientwidget_impl.h 0521765
> src/gradientwidget_impl.cpp 622717a
> src/isotopetable/isotopeguideview.h 560f3ba
> src/isotopetable/isotopeguideview.cpp d96ce80
> plasmoid/applet/psePlasmoid/Periodictable.cpp 5b75778
> plasmoid/engine/kalzium_engine.h 3e46481
> plasmoid/engine/kalzium_engine.cpp 36fce6f
> src/calculator/calculator.h cda195d
> src/calculator/calculator.cpp efe57aa
> src/calculator/concCalculator.h 54c1fa1
> src/calculator/concCalculator.cpp 785e77a
> src/calculator/gasCalculator.h 4cbcecf
> src/calculator/gasCalculator.cpp adef7f5
> src/calculator/nuclearCalculator.h f0230f8
> src/calculator/nuclearCalculator.cpp 488bd38
> src/calculator/titrationCalculator.h 9880ebe
> src/calculator/titrationCalculator.cpp 6c67887
> src/detailedQmlView.h 6c30912
> src/detailedQmlView.cpp 50321f5
> src/detailedgraphicaloverview.h 49d9980
> plasmoid/applet/didyouknow/didyouknow.h 4f402fe
> plasmoid/applet/didyouknow/didyouknow.cpp 11a04a8
> plasmoid/applet/gasPlasmoid/gasCalculator.h f552742
> plasmoid/applet/gasPlasmoid/gasCalculator.cpp de78078
> plasmoid/applet/nuclearPlasmoid/kalziumdataobject.h 9189dea
> plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp e802100
> plasmoid/applet/nuclearPlasmoid/nuclearCalculator.h d6ced65
> plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp dfcbc6d
> plasmoid/applet/psePlasmoid/Molmasscalculator.h ccd80e5
> plasmoid/applet/psePlasmoid/Molmasscalculator.cpp 4b6acbe
> plasmoid/applet/psePlasmoid/Periodictable.h 5c130cc
> libscience/isotopeparser.h c59aff4
> libscience/isotopeparser.cpp 0e646c1
> libscience/moleculeparser.h 3a41b8b
> libscience/moleculeparser.cpp 35321cc
> libscience/parser.h 9c9e209
> libscience/parser.cpp e34f189
> libscience/psetables.cpp d7e12a0
> libscience/spectrum.h 3d43d6f
> libscience/spectrum.cpp 9ce97a5
> libscience/spectrumparser.h 1e60a1c
> libscience/spectrumparser.cpp c89c114
> libscience/tests/xmlreadingtest.cpp 90a0e25
> plasmoid/applet/bodr/kalzium_plasma.h 94083e2
> plasmoid/applet/bodr/kalzium_plasma.cpp 6f312b3
> plasmoid/applet/concentrationPlasmoid/concentrationCalculator.h 5c27286
> plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp ac7f55b
>
> Diff: https://git.reviewboard.kde.org/r/120254/diff/
>
>
> Testing
> -------
>
> * compiling
> * running program
>
>
> Thanks,
>
> Martin Walch
>
>
--===============4663709477773373333==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120254/">https://git.reviewboard.kde.org/r/120254/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
honestly still don't see the point of this commit, you're reordering some includes \
most of the times just for "perfection" of sorting, well, i'm sorry to tell you the \
next guy that comes and patches is going to break it, for those things you either \
have commit hooks or will break, you also remove some local includes like cctype in \
one file, well the C++ includes are different in lots of systems, do you know that it \
will not break for example std::isdigit in there?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
most of your changes i see no real gain and i can forsee some pain.</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On setembre 20th, 2014, 1:39 a.m. UTC, Martin Walch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Martin Walch.</div>
<p style="color: grey;"><i>Updated set. 20, 2014, 1:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
normal;">src/calculator/titrationCalculator.cpp:</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">replace</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">if (!texto) {<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> QMessageBox::critical(this, "Error", "Unable to open " + file);<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> } <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> if (texto) {</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">if (!texto) {<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> QMessageBox::critical(this, "Error", "Unable to open " + file);<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> } else {</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">to emphasize that they are logically alternative</p> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
inherit;">src/calculator/titrationCalculator.cpp:<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> Fix \
"warning: 'cn' may be used uninitialized in this function".<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> As \
far as I see, this has no proper initialization at all and should<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
horribly fail. However, in all my tests it behaved as if it was properly<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> initialized with 0.0. Maybe there is some compiler (gcc) magic at \
work.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Nevermind. Just fix it.</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">libscience/spectrum.cpp:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> this line goes wrong</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">double newInt = p->intensity * 1000 / maxInt;<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
because all three of p->intensity, 1000, and maxInt are Integers. Fix it<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> with floating point number 1000.0. (The method is not used anywhere in<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> Kalzium, but it is part of the libscience library)</p>
</blockquote>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">further cleanup of includes:</p> </li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">replace</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<qclass.h></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<QtModule/QClass></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">replace</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<QtModule/QClass></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<QClass></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">replace</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<kclass.h></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<KClass></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">replace</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">#include \
<QtModule></p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with the classes of QtModule that are actually \
necessary.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">use forward declarations and move includes into cpp \
files</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">remove duplicate or unused includes</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(As a side note: single threaded build time reduced by roughly 5%)</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Drop C bindings in \
favor of explicit C++ bindings<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> (e.g. include cctype, not ctype.h and \
use std namespace)</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Replace abs() and isfinite() with their \
corresponding Qt equivalents<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> qAbs() and qIsFinite().</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Replace M_PI with const double PI = \
3.141... as M_PI is bad for<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> portability.</p>
</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">compiling</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">running program</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>compoundviewer/kalziumglpart.h <span style="color: grey">(0881df1)</span></li>
<li>compoundviewer/kalziumglpart.cpp <span style="color: grey">(001399d)</span></li>
<li>compoundviewer/openbabel2wrapper.cpp <span style="color: \
grey">(85406e1)</span></li>
<li>libscience/chemicaldataobject.h <span style="color: grey">(55a40dc)</span></li>
<li>libscience/chemicaldataobject.cpp <span style="color: \
grey">(8fac92c)</span></li>
<li>libscience/element.h <span style="color: grey">(43979d9)</span></li>
<li>libscience/element.cpp <span style="color: grey">(762462f)</span></li>
<li>libscience/elementparser.h <span style="color: grey">(f3a8130)</span></li>
<li>libscience/elementparser.cpp <span style="color: grey">(7c5ecaf)</span></li>
<li>libscience/isotope.cpp <span style="color: grey">(91db538)</span></li>
<li>src/psetable/elementitem.cpp <span style="color: grey">(a2b238c)</span></li>
<li>src/psetable/numerationitem.h <span style="color: grey">(5cf8afb)</span></li>
<li>src/psetable/numerationitem.cpp <span style="color: grey">(574f74f)</span></li>
<li>src/psetable/periodictablescene.h <span style="color: \
grey">(c89044b)</span></li>
<li>src/psetable/periodictablescene.cpp <span style="color: \
grey">(5ea99c0)</span></li>
<li>src/psetable/periodictablestates.h <span style="color: \
grey">(f8258c3)</span></li>
<li>src/psetable/periodictablestates.cpp <span style="color: \
grey">(501b75e)</span></li>
<li>src/psetable/periodictableview.h <span style="color: grey">(366480e)</span></li>
<li>src/psetable/periodictableview.cpp <span style="color: \
grey">(9669e5b)</span></li>
<li>src/psetable/statemachine.h <span style="color: grey">(0cad142)</span></li>
<li>src/psetable/statemachine.cpp <span style="color: grey">(9ce8d58)</span></li>
<li>src/rsdialog.h <span style="color: grey">(930276c)</span></li>
<li>src/rsdialog.cpp <span style="color: grey">(64a6b60)</span></li>
<li>src/search.h <span style="color: grey">(83bcf66)</span></li>
<li>src/search.cpp <span style="color: grey">(7ff6464)</span></li>
<li>src/isotopetable/isotopeitem.h <span style="color: grey">(5b7840b)</span></li>
<li>src/isotopetable/isotopeitem.cpp <span style="color: grey">(b98155d)</span></li>
<li>src/isotopetable/isotopescene.cpp <span style="color: \
grey">(18f6a54)</span></li>
<li>src/isotopetable/isotopetabledialog.h <span style="color: \
grey">(4f075c5)</span></li>
<li>src/isotopetable/isotopetabledialog.cpp <span style="color: \
grey">(83fb000)</span></li>
<li>src/isotopetable/isotopeview.h <span style="color: grey">(54d3d97)</span></li>
<li>src/isotopetable/isotopeview.cpp <span style="color: grey">(dd6bc8e)</span></li>
<li>src/kalzium.h <span style="color: grey">(86e4a6d)</span></li>
<li>src/kalzium.cpp <span style="color: grey">(2e85cf8)</span></li>
<li>src/kalziumdataobject.h <span style="color: grey">(0d88856)</span></li>
<li>src/kalziumdataobject.cpp <span style="color: grey">(e962670)</span></li>
<li>src/kalziumelementproperty.h <span style="color: grey">(f8b3a67)</span></li>
<li>src/kalziumelementproperty.cpp <span style="color: grey">(c42ecd5)</span></li>
<li>src/kalziumgradienttype.cpp <span style="color: grey">(5130f85)</span></li>
<li>src/kalziumnumerationtype.cpp <span style="color: grey">(52275d0)</span></li>
<li>src/kalziumschemetype.h <span style="color: grey">(a6447d5)</span></li>
<li>src/kalziumschemetype.cpp <span style="color: grey">(d35a97c)</span></li>
<li>src/kalziumutils.h <span style="color: grey">(0938b34)</span></li>
<li>src/kalziumutils.cpp <span style="color: grey">(bae9c54)</span></li>
<li>src/kdeeduglossary.h <span style="color: grey">(3b47aee)</span></li>
<li>src/kdeeduglossary.cpp <span style="color: grey">(f561568)</span></li>
<li>src/legendwidget.h <span style="color: grey">(9794f07)</span></li>
<li>src/legendwidget.cpp <span style="color: grey">(b0a7ba0)</span></li>
<li>src/main.cpp <span style="color: grey">(ff492f0)</span></li>
<li>src/molcalcwidget.h <span style="color: grey">(a0581a0)</span></li>
<li>src/molcalcwidget.cpp <span style="color: grey">(784928a)</span></li>
<li>src/orbitswidget.cpp <span style="color: grey">(d94ccf1)</span></li>
<li>src/psetable/elementitem.h <span style="color: grey">(7dd7e30)</span></li>
<li>src/searchwidget.cpp <span style="color: grey">(17edc1b)</span></li>
<li>src/spectrumviewimpl.h <span style="color: grey">(881609f)</span></li>
<li>src/spectrumviewimpl.cpp <span style="color: grey">(f9c0488)</span></li>
<li>src/spectrumwidget.h <span style="color: grey">(4caecb4)</span></li>
<li>src/spectrumwidget.cpp <span style="color: grey">(2264590)</span></li>
<li>src/tableinfowidget.h <span style="color: grey">(dcfeea7)</span></li>
<li>src/tableinfowidget.cpp <span style="color: grey">(48eb865)</span></li>
<li>src/tablesdialog.h <span style="color: grey">(a04f4ad)</span></li>
<li>src/tablesdialog.cpp <span style="color: grey">(6dd126e)</span></li>
<li>src/tools/moleculeview.h <span style="color: grey">(73bf9b8)</span></li>
<li>src/tools/moleculeview.cpp <span style="color: grey">(7a6c9f3)</span></li>
<li>src/tools/obconverter.cpp <span style="color: grey">(04b557d)</span></li>
<li>src/unitsettingsdialog.h <span style="color: grey">(04d5cf0)</span></li>
<li>src/unitsettingsdialog.cpp <span style="color: grey">(4f50aca)</span></li>
<li>src/detailedgraphicaloverview.cpp <span style="color: \
grey">(5fb716b)</span></li>
<li>src/detailinfodlg.h <span style="color: grey">(e81802b)</span></li>
<li>src/detailinfodlg.cpp <span style="color: grey">(5932a7f)</span></li>
<li>src/elementdataviewer.h <span style="color: grey">(dba156e)</span></li>
<li>src/elementdataviewer.cpp <span style="color: grey">(49a2a18)</span></li>
<li>src/eqchemview.h <span style="color: grey">(59d3384)</span></li>
<li>src/eqchemview.cpp <span style="color: grey">(ebce0be)</span></li>
<li>src/exportdialog.h <span style="color: grey">(7aa5543)</span></li>
<li>src/exportdialog.cpp <span style="color: grey">(a21dc26)</span></li>
<li>src/gradientwidget_impl.h <span style="color: grey">(0521765)</span></li>
<li>src/gradientwidget_impl.cpp <span style="color: grey">(622717a)</span></li>
<li>src/isotopetable/isotopeguideview.h <span style="color: \
grey">(560f3ba)</span></li>
<li>src/isotopetable/isotopeguideview.cpp <span style="color: \
grey">(d96ce80)</span></li>
<li>plasmoid/applet/psePlasmoid/Periodictable.cpp <span style="color: \
grey">(5b75778)</span></li>
<li>plasmoid/engine/kalzium_engine.h <span style="color: grey">(3e46481)</span></li>
<li>plasmoid/engine/kalzium_engine.cpp <span style="color: \
grey">(36fce6f)</span></li>
<li>src/calculator/calculator.h <span style="color: grey">(cda195d)</span></li>
<li>src/calculator/calculator.cpp <span style="color: grey">(efe57aa)</span></li>
<li>src/calculator/concCalculator.h <span style="color: grey">(54c1fa1)</span></li>
<li>src/calculator/concCalculator.cpp <span style="color: \
grey">(785e77a)</span></li>
<li>src/calculator/gasCalculator.h <span style="color: grey">(4cbcecf)</span></li>
<li>src/calculator/gasCalculator.cpp <span style="color: grey">(adef7f5)</span></li>
<li>src/calculator/nuclearCalculator.h <span style="color: \
grey">(f0230f8)</span></li>
<li>src/calculator/nuclearCalculator.cpp <span style="color: \
grey">(488bd38)</span></li>
<li>src/calculator/titrationCalculator.h <span style="color: \
grey">(9880ebe)</span></li>
<li>src/calculator/titrationCalculator.cpp <span style="color: \
grey">(6c67887)</span></li>
<li>src/detailedQmlView.h <span style="color: grey">(6c30912)</span></li>
<li>src/detailedQmlView.cpp <span style="color: grey">(50321f5)</span></li>
<li>src/detailedgraphicaloverview.h <span style="color: grey">(49d9980)</span></li>
<li>plasmoid/applet/didyouknow/didyouknow.h <span style="color: \
grey">(4f402fe)</span></li>
<li>plasmoid/applet/didyouknow/didyouknow.cpp <span style="color: \
grey">(11a04a8)</span></li>
<li>plasmoid/applet/gasPlasmoid/gasCalculator.h <span style="color: \
grey">(f552742)</span></li>
<li>plasmoid/applet/gasPlasmoid/gasCalculator.cpp <span style="color: \
grey">(de78078)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.h <span style="color: \
grey">(9189dea)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp <span style="color: \
grey">(e802100)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.h <span style="color: \
grey">(d6ced65)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp <span style="color: \
grey">(dfcbc6d)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.h <span style="color: \
grey">(ccd80e5)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.cpp <span style="color: \
grey">(4b6acbe)</span></li>
<li>plasmoid/applet/psePlasmoid/Periodictable.h <span style="color: \
grey">(5c130cc)</span></li>
<li>libscience/isotopeparser.h <span style="color: grey">(c59aff4)</span></li>
<li>libscience/isotopeparser.cpp <span style="color: grey">(0e646c1)</span></li>
<li>libscience/moleculeparser.h <span style="color: grey">(3a41b8b)</span></li>
<li>libscience/moleculeparser.cpp <span style="color: grey">(35321cc)</span></li>
<li>libscience/parser.h <span style="color: grey">(9c9e209)</span></li>
<li>libscience/parser.cpp <span style="color: grey">(e34f189)</span></li>
<li>libscience/psetables.cpp <span style="color: grey">(d7e12a0)</span></li>
<li>libscience/spectrum.h <span style="color: grey">(3d43d6f)</span></li>
<li>libscience/spectrum.cpp <span style="color: grey">(9ce97a5)</span></li>
<li>libscience/spectrumparser.h <span style="color: grey">(1e60a1c)</span></li>
<li>libscience/spectrumparser.cpp <span style="color: grey">(c89c114)</span></li>
<li>libscience/tests/xmlreadingtest.cpp <span style="color: \
grey">(90a0e25)</span></li>
<li>plasmoid/applet/bodr/kalzium_plasma.h <span style="color: \
grey">(94083e2)</span></li>
<li>plasmoid/applet/bodr/kalzium_plasma.cpp <span style="color: \
grey">(6f312b3)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/concentrationCalculator.h <span \
style="color: grey">(5c27286)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp <span \
style="color: grey">(ac7f55b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120254/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4663709477773373333==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic