[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 120275: Refactor #2 in parley
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2014-09-19 1:51:09
Message-ID: 20140919015109.7376.86853 () probe ! kde ! org
[Download RAW message or body]
--===============3299151706959392160==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120275/
-----------------------------------------------------------
(Updated Sept. 19, 2014, 1:51 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Amarvir Singh, Andreas Xavier, and Jeremy Whiting.
Repository: parley
Description
-------
This is the continuation of my last refactoring of parley which would lead to a \
better separation of model and view. This one contains:
- Moving of views in src/vocabulary/ to src/collection/ and src/editor/
- Removing of the src/export/ directory (there were only 3 files in there)
- Removing of the Editor namespace outside the actual editor.
There should be no functional changes and only moving of files and some followup \
changes like the CMakelists.txt file.
After this change I will start to introduce real code changes which may have to be \
reviewed in more detail.
Diffs
-----
src/CMakeLists.txt aea7fe3
src/collection/containermimedata.h 6ce4bba
src/collection/containermimedata.cpp 9a81aa0
src/collection/containermodel.h a194f88
src/collection/containermodel.cpp 49bbe86
src/collection/containerview.h PRE-CREATION
src/editor/vocabularycolumnsdialog.cpp PRE-CREATION
src/editor/vocabularydelegate.h PRE-CREATION
src/editor/vocabularydelegate.cpp PRE-CREATION
src/editor/vocabularyheaderview.h PRE-CREATION
src/editor/vocabularyheaderview.cpp PRE-CREATION
src/editor/vocabularyview.h PRE-CREATION
src/editor/vocabularyview.cpp PRE-CREATION
src/editor/wordtypeview.h PRE-CREATION
src/collection/containerview.cpp PRE-CREATION
src/collection/entryfilter.h 7122ef6
src/collection/entryfilter.cpp 614981f
src/collection/lessonmodel.h 8f5ffa0
src/collection/lessonmodel.cpp 72335c4
src/collection/readonlycontainermodel.h bd19167
src/collection/readonlycontainermodel.cpp e2ea6f5
src/collection/vocabularyfilter.h PRE-CREATION
src/collection/vocabularyfilter.cpp PRE-CREATION
src/collection/vocabularymimedata.h 99b367c
src/collection/vocabularymimedata.cpp d071b1f
src/collection/vocabularymodel.h d77ce9e
src/collection/vocabularymodel.cpp 158db0d
src/collection/wordclassmodel.h d7955ef
src/collection/wordclassmodel.cpp 5d56aaa
src/editor/editor.h 546c9a5
src/editor/editor.cpp 68e5bed
src/editor/latexwidget.h f1aed27
src/editor/latexwidget.cpp dbe6251
src/editor/lessonview.h PRE-CREATION
src/editor/lessonview.cpp PRE-CREATION
src/editor/summarywordwidget.h a9c3e75
src/editor/summarywordwidget.cpp f3d67f7
src/editor/vocabularycolumnsdialog.h PRE-CREATION
src/vocabulary/vocabularyview.cpp 8bb7f7e
src/vocabulary/wordtypeview.h dbb26ea
src/vocabulary/wordtypeview.cpp 5d9edbd
src/vocabulary/vocabularyfilter.h b5655fe
src/vocabulary/vocabularyfilter.cpp 37ab1e6
src/vocabulary/vocabularyheaderview.h 7e6e4e5
src/vocabulary/vocabularyheaderview.cpp 0b2572e
src/vocabulary/vocabularyview.h 0fdd771
src/vocabulary/lessonview.h b2a2476
src/vocabulary/lessonview.cpp af3a36d
src/vocabulary/vocabularycolumnsdialog.h 376c103
src/vocabulary/vocabularycolumnsdialog.cpp d8fd5f7
src/vocabulary/vocabularydelegate.h be17eaa
src/vocabulary/vocabularydelegate.cpp 7c4b1b6
src/vocabulary/containerview.h 379dd13
src/vocabulary/containerview.cpp 42e6c1c
src/vocabulary/leitnerview.cpp 1d50686
src/parleymainwindow.h 87361d7
src/scripts/scripting/parley.cpp 10b0c31
src/statistics/lessonstatistics.h 42597c6
src/statistics/lessonstatistics.cpp 64b5f18
src/statistics/statisticsmainwindow.cpp cbed13d
src/statistics/statisticsmodel.h 19b2115
src/export/exportdialog.h 2c84053
src/export/exportdialog.cpp 9b4319f
src/export/exportdialog.ui 4ac26bf
src/exportdialog.h PRE-CREATION
src/exportdialog.cpp PRE-CREATION
src/exportdialog.ui PRE-CREATION
src/parleydocument.cpp ee4fc93
src/editor/wordtypeview.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120275/diff/
Testing
-------
Lots of checks after each move.
Thanks,
Inge Wallin
--===============3299151706959392160==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120275/">https://git.reviewboard.kde.org/r/120275/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Amarvir Singh, Andreas Xavier, and Jeremy \
Whiting.</div> <div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 1:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is the continuation of my last refactoring of \
parley which would lead to a better separation of model and view. This one \
contains:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
- Moving of views in src/vocabulary/ to src/collection/ and src/editor/<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- Removing of the src/export/ directory (there were only 3 files in there)<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- Removing of the Editor namespace outside the actual editor.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There should be no functional changes and only moving \
of files and some followup changes like the CMakelists.txt file.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">After this change I will start to introduce real code changes which may \
have to be reviewed in more detail.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Lots of checks after each move.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(aea7fe3)</span></li>
<li>src/collection/containermimedata.h <span style="color: \
grey">(6ce4bba)</span></li>
<li>src/collection/containermimedata.cpp <span style="color: \
grey">(9a81aa0)</span></li>
<li>src/collection/containermodel.h <span style="color: grey">(a194f88)</span></li>
<li>src/collection/containermodel.cpp <span style="color: \
grey">(49bbe86)</span></li>
<li>src/collection/containerview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularycolumnsdialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularydelegate.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularydelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularyheaderview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularyheaderview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularyview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/editor/vocabularyview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/editor/wordtypeview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/collection/containerview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/collection/entryfilter.h <span style="color: grey">(7122ef6)</span></li>
<li>src/collection/entryfilter.cpp <span style="color: grey">(614981f)</span></li>
<li>src/collection/lessonmodel.h <span style="color: grey">(8f5ffa0)</span></li>
<li>src/collection/lessonmodel.cpp <span style="color: grey">(72335c4)</span></li>
<li>src/collection/readonlycontainermodel.h <span style="color: \
grey">(bd19167)</span></li>
<li>src/collection/readonlycontainermodel.cpp <span style="color: \
grey">(e2ea6f5)</span></li>
<li>src/collection/vocabularyfilter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/collection/vocabularyfilter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/collection/vocabularymimedata.h <span style="color: \
grey">(99b367c)</span></li>
<li>src/collection/vocabularymimedata.cpp <span style="color: \
grey">(d071b1f)</span></li>
<li>src/collection/vocabularymodel.h <span style="color: grey">(d77ce9e)</span></li>
<li>src/collection/vocabularymodel.cpp <span style="color: \
grey">(158db0d)</span></li>
<li>src/collection/wordclassmodel.h <span style="color: grey">(d7955ef)</span></li>
<li>src/collection/wordclassmodel.cpp <span style="color: \
grey">(5d56aaa)</span></li>
<li>src/editor/editor.h <span style="color: grey">(546c9a5)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(68e5bed)</span></li>
<li>src/editor/latexwidget.h <span style="color: grey">(f1aed27)</span></li>
<li>src/editor/latexwidget.cpp <span style="color: grey">(dbe6251)</span></li>
<li>src/editor/lessonview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/editor/lessonview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/editor/summarywordwidget.h <span style="color: grey">(a9c3e75)</span></li>
<li>src/editor/summarywordwidget.cpp <span style="color: grey">(f3d67f7)</span></li>
<li>src/editor/vocabularycolumnsdialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/vocabulary/vocabularyview.cpp <span style="color: \
grey">(8bb7f7e)</span></li>
<li>src/vocabulary/wordtypeview.h <span style="color: grey">(dbb26ea)</span></li>
<li>src/vocabulary/wordtypeview.cpp <span style="color: grey">(5d9edbd)</span></li>
<li>src/vocabulary/vocabularyfilter.h <span style="color: \
grey">(b5655fe)</span></li>
<li>src/vocabulary/vocabularyfilter.cpp <span style="color: \
grey">(37ab1e6)</span></li>
<li>src/vocabulary/vocabularyheaderview.h <span style="color: \
grey">(7e6e4e5)</span></li>
<li>src/vocabulary/vocabularyheaderview.cpp <span style="color: \
grey">(0b2572e)</span></li>
<li>src/vocabulary/vocabularyview.h <span style="color: grey">(0fdd771)</span></li>
<li>src/vocabulary/lessonview.h <span style="color: grey">(b2a2476)</span></li>
<li>src/vocabulary/lessonview.cpp <span style="color: grey">(af3a36d)</span></li>
<li>src/vocabulary/vocabularycolumnsdialog.h <span style="color: \
grey">(376c103)</span></li>
<li>src/vocabulary/vocabularycolumnsdialog.cpp <span style="color: \
grey">(d8fd5f7)</span></li>
<li>src/vocabulary/vocabularydelegate.h <span style="color: \
grey">(be17eaa)</span></li>
<li>src/vocabulary/vocabularydelegate.cpp <span style="color: \
grey">(7c4b1b6)</span></li>
<li>src/vocabulary/containerview.h <span style="color: grey">(379dd13)</span></li>
<li>src/vocabulary/containerview.cpp <span style="color: grey">(42e6c1c)</span></li>
<li>src/vocabulary/leitnerview.cpp <span style="color: grey">(1d50686)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(87361d7)</span></li>
<li>src/scripts/scripting/parley.cpp <span style="color: grey">(10b0c31)</span></li>
<li>src/statistics/lessonstatistics.h <span style="color: \
grey">(42597c6)</span></li>
<li>src/statistics/lessonstatistics.cpp <span style="color: \
grey">(64b5f18)</span></li>
<li>src/statistics/statisticsmainwindow.cpp <span style="color: \
grey">(cbed13d)</span></li>
<li>src/statistics/statisticsmodel.h <span style="color: grey">(19b2115)</span></li>
<li>src/export/exportdialog.h <span style="color: grey">(2c84053)</span></li>
<li>src/export/exportdialog.cpp <span style="color: grey">(9b4319f)</span></li>
<li>src/export/exportdialog.ui <span style="color: grey">(4ac26bf)</span></li>
<li>src/exportdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/exportdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/exportdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/parleydocument.cpp <span style="color: grey">(ee4fc93)</span></li>
<li>src/editor/wordtypeview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120275/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3299151706959392160==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic