[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 120129: Fix Iteration of Array mm
From: David_Narváez <david.narvaez () computer ! org>
Date: 2014-09-12 14:35:44
Message-ID: 20140912143544.8755.6473 () probe ! kde ! org
[Download RAW message or body]
--===============3826356984505491130==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120129/
-----------------------------------------------------------
(Updated Sept. 12, 2014, 2:35 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Maurizio Paolini and Rex Dieter.
Bugs: 338978
http://bugs.kde.org/show_bug.cgi?id=338978
Repository: kig
Description
-------
Because of the initial value of j it was missing j = 1, causing Valgrind to report a \
jump over uninitialized value. Because of the check at the while loop, it was \
modifying j = N + 1, causing a stack buffer overflow.
Diffs
-----
objects/curve_imp.cc 12931c8
Diff: https://git.reviewboard.kde.org/r/120129/diff/
Testing
-------
Valgrinded an execution of Kig creating a locus as described in the bug report.
Thanks,
David Narváez
--===============3826356984505491130==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120129/">https://git.reviewboard.kde.org/r/120129/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Maurizio Paolini and Rex Dieter.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2014, 2:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=338978">338978</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Because of the initial value of j it was missing j = \
1, causing Valgrind to report a jump over uninitialized value. Because of the check \
at the while loop, it was modifying j = N + 1, causing a stack buffer \
overflow.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Valgrinded an execution of Kig creating a locus as \
described in the bug report.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>objects/curve_imp.cc <span style="color: grey">(12931c8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120129/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3826356984505491130==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic