[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 119905: Parley: Fix bugs: 338302 and 338417 title bar [modified] tag behavior is
From: "Andreas Xavier" <andxav () zoho ! com>
Date: 2014-08-23 18:23:32
Message-ID: 20140823182332.8733.57013 () probe ! kde ! org
[Download RAW message or body]
--===============2466935780695483258==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119905/
-----------------------------------------------------------
(Updated Aug. 23, 2014, 6:23 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Bugs: 338302 and 338417
http://bugs.kde.org/show_bug.cgi?id=338302
http://bugs.kde.org/show_bug.cgi?id=338417
Repository: parley
Description
-------
Symptoms:
The [modified] in the title bar was inconsistent.
Problems:
1. The title bar was only connected to the dirty bit in the doc from the Editor. \
Going directly welcome -> stats did not connect the title bar to the dirty bit. 2. \
Whenever a new document was created, new collection, welcome screen etc. the title \
bar was disconnected. 3. In several places setModified was called on the kvocdoc when \
either nothing changed or the kvocdoc should know better.
Solution:
The title bar is ParleyMainWindow's title bar. ParleyMainWindow also know when the \
document is updated. I created a updateParleyDocument so that ParleyMainWindow \
always knows when the doc changes and slotFileNew so that anyone can ask \
ParleyMainWindow to update its own title bar.
Not fixed: Parley still directly calls the setModified in kvocdoc when it starts \
practice. kvocdoc needs to be fixed before that is removed.
Diffs
-----
src/editor/editor.cpp 4fac862
src/parleydocument.cpp 0ebeca1
src/parleymainwindow.h 98a94ad
src/parleymainwindow.cpp 9723ee1
src/practice/practicemainwindow.cpp 3008501
src/settings/documentproperties.cpp 02cbf7b
src/settings/languageproperties.cpp e9b171f
src/vocabulary/vocabularymodel.cpp abf0db9
src/welcomescreen/welcomescreen.cpp d24f444
Diff: https://git.reviewboard.kde.org/r/119905/diff/
Testing
-------
Clicked from welcomescreen -> stats -> practice -> exit stats
Clicked from welcomscreen -> stats -> editor (edited) -> practice
Clicked from welcomscreen -> stats -> editor (no edit) -> practice
Created a new collection from welcome screen
Changed doc properties from stats->File->Properties.
All of these cases worked correctly
Thanks,
Andreas Xavier
--===============2466935780695483258==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119905/">https://git.reviewboard.kde.org/r/119905/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Andreas Xavier.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2014, 6:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=338302">338302</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=338417">338417</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Symptoms:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> The [modified] in the \
title bar was inconsistent.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Problems:<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 1. \
The title bar was only connected to the dirty bit in the doc from the Editor. Going \
directly welcome -> stats did not connect the title bar to the dirty bit.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> 2. Whenever a new document was created, new collection, welcome screen \
etc. the title bar was disconnected.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> 3. In several places \
setModified was called on the kvocdoc when either nothing changed or the kvocdoc \
should know better.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Solution:<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> The \
title bar is ParleyMainWindow's title bar. ParleyMainWindow also know when the \
document is updated. I created a updateParleyDocument so that ParleyMainWindow \
always knows when the doc changes and slotFileNew so that anyone can ask \
ParleyMainWindow to update its own title bar.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
fixed: Parley still directly calls the setModified in kvocdoc when it starts \
practice. kvocdoc needs to be fixed before that is removed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Clicked from welcomescreen -> stats -> practice \
-> exit stats<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Clicked from welcomscreen -> stats -> editor \
(edited) -> practice<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Clicked from welcomscreen -> stats \
-> editor (no edit) -> practice<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Created a new \
collection from welcome screen<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Changed doc properties from \
stats->File->Properties.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">All of these cases \
worked correctly</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.cpp <span style="color: grey">(4fac862)</span></li>
<li>src/parleydocument.cpp <span style="color: grey">(0ebeca1)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(98a94ad)</span></li>
<li>src/parleymainwindow.cpp <span style="color: grey">(9723ee1)</span></li>
<li>src/practice/practicemainwindow.cpp <span style="color: \
grey">(3008501)</span></li>
<li>src/settings/documentproperties.cpp <span style="color: \
grey">(02cbf7b)</span></li>
<li>src/settings/languageproperties.cpp <span style="color: \
grey">(e9b171f)</span></li>
<li>src/vocabulary/vocabularymodel.cpp <span style="color: \
grey">(abf0db9)</span></li>
<li>src/welcomescreen/welcomescreen.cpp <span style="color: \
grey">(d24f444)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119905/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2466935780695483258==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic