'Re: Review Request 119852: [Kig] Support for Geogebra's Line-Line Intersection.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 119852: [Kig] Support for Geogebra's Line-Line Intersection.
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2014-08-20 12:45:19
Message-ID: 20140820124519.26014.74643 () probe ! kde ! org
[Download RAW message or body]

--===============0121017474386435844==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119852/#review64910
-----------------------------------------------------------

Ship it!

And please update the patch at RR 119621 to have this part removed

- David Narváez

On Aug. 20, 2014, 7:25 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119852/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 7:25 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables Kig to read Geogebra's Line-Line Intersection objects.
> 
> 
> Diffs
> -----
> 
> geogebra/geogebra.xsl 87ef07b 
> 
> Diff: https://git.reviewboard.kde.org/r/119852/diff/
> 
> 
> Testing
> -------
> 
> Tested with a file containing three lines, each intersecting the other two. 
> 
> 
> File Attachments
> ----------------
> 
> Line Line Intersection
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/790a15da-19b3-47e6-aaaa-a75332ca4dec__ll.ggb
>  
> 
> Thanks,
> 
> Aniket Anvit
> 
> 

--===============0121017474386435844==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119852/">https://git.reviewboard.kde.org/r/119852/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And \
please update the patch at RR 119621 to have this part removed</p></pre>  <br />

<p>- David Narváez</p>

<br />
<p>On August 20th, 2014, 7:25 a.m. UTC, Aniket Anvit wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>

<p style="color: grey;"><i>Updated Aug. 20, 2014, 7:25 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch enables Kig to read Geogebra's Line-Line \
Intersection objects.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with a file containing three lines, each \
intersecting the other two. </p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>geogebra/geogebra.xsl <span style="color: grey">(87ef07b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119852/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/790a15da-19b3-47e6-aaaa-a75332ca4dec__ll.ggb">Line \
Line Intersection</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0121017474386435844==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 