[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118942: support for gogebra's tools in kig ( GSoC 14 )
From: David_Narváez <david.narvaez () computer ! org>
Date: 2014-07-21 7:14:58
Message-ID: 20140721071458.14617.2064 () probe ! kde ! org
[Download RAW message or body]
--===============0147910249249436556==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118942/#review62756
-----------------------------------------------------------
Ship it!
Great job with this patch!
- David Narváez
On July 21, 2014, 5:51 a.m., Aniket Anvit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118942/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 5:51 a.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Repository: kig
>
>
> Description
> -------
>
> This patch adds support for Geogebra's tool files ( .ggt files ) in kig.
>
>
> Diffs
> -----
>
> CMakeLists.txt 4b2d286
> filters/geogebra-filter.h 1b2b416
> filters/geogebra-filter.cpp 53c9253
> filters/geogebra.qrc bfe493a
> filters/geogebra.xsl a0809da
> geogebra/geogebra.qrc PRE-CREATION
> geogebra/geogebra.xsl PRE-CREATION
> geogebra/geogebrasection.h PRE-CREATION
> geogebra/geogebrasection.cpp PRE-CREATION
> geogebra/geogebratransformer.h PRE-CREATION
> geogebra/geogebratransformer.cpp PRE-CREATION
> modes/typesdialog.h ae245e2
> modes/typesdialog.cpp d14d0fe
>
> Diff: https://git.reviewboard.kde.org/r/118942/diff/
>
>
> Testing
> -------
>
> To open a tool file, open them from the types-dialog.
> I tested with a tool which takes 2 points and gives a line , midpoint, and a circle \
> from these two points. Tested with another tool which took three points and gave a \
> circle, hyperbola and an ellipse from these points. Only those tools will be \
> supported which contain only the geogebra-objects which are currently supported by \
> kig.
>
> Thanks,
>
> Aniket Anvit
>
>
--===============0147910249249436556==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118942/">https://git.reviewboard.kde.org/r/118942/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Great \
job with this patch!</p></pre> <br />
<p>- David Narváez</p>
<br />
<p>On July 21st, 2014, 5:51 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated July 21, 2014, 5:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds support for Geogebra's tool files ( \
.ggt files ) in kig.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To open a tool file, open them from the \
types-dialog.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> I tested with a tool which takes 2 points and gives \
a line , midpoint, and a circle from these two points.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Tested with another tool which took three points and gave a circle, hyperbola and an \
ellipse from these points.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Only those tools will be supported \
which contain only the geogebra-objects which are currently supported by \
kig.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4b2d286)</span></li>
<li>filters/geogebra-filter.h <span style="color: grey">(1b2b416)</span></li>
<li>filters/geogebra-filter.cpp <span style="color: grey">(53c9253)</span></li>
<li>filters/geogebra.qrc <span style="color: grey">(bfe493a)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(a0809da)</span></li>
<li>geogebra/geogebra.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebra.xsl <span style="color: grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebrasection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebrasection.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebratransformer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebratransformer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>modes/typesdialog.h <span style="color: grey">(ae245e2)</span></li>
<li>modes/typesdialog.cpp <span style="color: grey">(d14d0fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118942/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0147910249249436556==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic