[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118904: support for Geogebra's polygon-n-points, polyline,
From: David_Narváez <david.narvaez () computer ! org>
Date: 2014-06-30 7:35:25
Message-ID: 20140630073525.19305.6392 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118904/#review61252
-----------------------------------------------------------
Ship it!
Ship It!
- David Narváez
On June 30, 2014, 4:47 a.m., Aniket Anvit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118904/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 4:47 a.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Repository: kig
>
>
> Description
> -------
>
> This patch adds support for Geogebra's Polygon-by-n-points, Reflection-in-point, \
> Reflection-in-Line, Reflection-in-circle ( Reflection-in-circle doesn't support \
> reflection of polygons though ), Dilate, Translate, Vector objects/transformations \
> in Kig.
>
> Diffs
> -----
>
> filters/geogebra-filter.cpp d40f976
> filters/geogebra.xsl 668d758
>
> Diff: https://git.reviewboard.kde.org/r/118904/diff/
>
>
> Testing
> -------
>
> Tested with multiple objects of each type.
>
>
> Thanks,
>
> Aniket Anvit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118904/">https://git.reviewboard.kde.org/r/118904/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Narváez</p>
<br />
<p>On June 30th, 2014, 4:47 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 4:47 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for Geogebra's Polygon-by-n-points, \
Reflection-in-point, Reflection-in-Line, Reflection-in-circle ( Reflection-in-circle \
doesn't support reflection of polygons though ), Dilate, Translate, Vector \
objects/transformations in Kig.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with multiple objects of each type.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/geogebra-filter.cpp <span style="color: grey">(d40f976)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(668d758)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118904/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic